Git Product home page Git Product logo

hn's People

Contributors

premii avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hn's Issues

Forked for significant refactoring

I have forked this project and have already made significant contributions towards modernizing it. Here's the list of added support and improvements:

  • ES6/7 support with babel
  • Webpack support
  • Extracted copy/pasted dependencies from source to npm dependencies
  • ESLint support
  • Travis CI support
  • Isomorphic Fetch API

I plan on adding / migrating to:

  • React/Preact
  • Mocha tests
  • Sass support with postcss autoprefixer support, minification, concatenation
  • Migration to localforage as an abstraction for localStorage

@premii It would be nice if you or other contributors can contribute to my fork, which I hope will be merged later when finished

Simple readability ehancement for web http://hn.premii.com

Hello and thanks for your app again, I really like it. I like it and use it, that's why I notice what follow.

For a better readability in web browsers, I would suggest to reduce the .article-content p and .comment div widths to 60%. It will increase height of posts and scrolling, but actually, width is so hight that it's almost impossible to read, because when your eye change from one line to an other, it is lost, and it make the reading much more difficult.

Maybe 60% is not exactly the right size but it looks like this :

hn premii com articles
hn premii com comments

I believe a max-width in desktop browsers context will also be an interesting thing.

This is not a UI rule, this is something I learned from books typography. The problem doesn't occurs on portrait position on phones because it has the size of a book page, but on a large computer screen, you should change this.

I you don't have time for this I can send you a pull request.

Sorry for any mistake in English grammar and I hope it could help.

Removing console log

Thanks for making this. It is a lifesaver for proxies!

There is a console.log called on line 137 of notify.min.js on live:

    var showContent = function(data) {
        console.log(data);
        var show = true;
        if (data.frequency) {
            if (notifyHistory(data.id, data.frequency)) {
                show = false;
            }
            else if (data.showThis) {
                show = data.showThis();
            }
        }

I would have created a PR but it seems that build isn't on GitHub.

App doesn't automatically return to full screen

iPhone 6+ has the feature where you double tap home, and the app resizes itself to half the original height.

When this is done in the HN app the app will never return to full screen. Simply stays smaller, you need to tap the black empty area above the app to force it to return to original size.

Authentication

Do you plan to add authentication support to the app? It would be useful to upvote stories and comments.

Add commenting

Right now this app is used only for reading, it would be greate to add possibility to login to HN and leave a comment.

Use iframe when unable to load the content

Using the webversion, many sites seem to block loading the content by now. So instead of trying to load it in the app and make it appear nice, you could use an iframe as a fallback to display the site. This way users can stay in the app.

Include submission title in comments page <title> HTML tag

Hi, great app!

It would be really helpful if the comments title were set as the title of the submission. It seems like it would be simple to use the title from the hacker news API instead of the current title on each comments section, "Hacker News".

This would also mirror how hacker news does its own comments and help my tabbed browsing tremendously. Thanks!!

iOS app sharing gives out unfriendly URL

When I share an article on iOS to another app, say Telegram, this is what shows up:

http://hn.premii.com/#/article/11219208

Hacker News
Read Hacker News articles and comments with this clean, simple, modern looking and fast performing universal app.

Here's a screenshot:
image

This isn't very user-friendly as there is no preview: no article title, no article-specific snippet. This would work a lot better if the app didn't share URLs to the premii web UI (this is slower for recipients anyway). Instead, the app should share the standard URL, e.g. https://news.ycombinator.com/item?id=11219208

At least, it would be great if we had a setting to use the standard Hacker News URLs.

Web pages open in Safari, not Safari View Controller

Since the update on 2018-01-05, web views no longer open in Safari View Controller.

Tap on an article
Tap on the URL at the top
Expected: opens Safari View Controller with web view
Actual: switches to Safari and opens link there

Add Month's best

Please add the Month's best HN stories next to the Week's best.

Wrong Website Loaded

I just wanted to let you know that the article http://hn.premii.com/#/article/8749605/ points to the wrong article on both the web app and on the android app. When I follow the link http://www.sciencealert.com/this-plane-will-be-able-to-fly-anywhere-in-the-world-within-4-hours it is the correct article. Currently an article about mummies shows up.

Thank you for the awesome app and I just wanted to let you know in case you were interetsed in figuring out why it points to the wrong article.

no way to navigate back to stories when saved to springboard

When its opened from the home screen on my ipad or iphone, it opens without chrome thanks to the apple meta tags. Seems nice, til you try to go to the original story, then go back—there's no back button, and swiping doesn't work. the only way for me to get back to the app is to hit the home button then go back into the app. I like the chromeless aspect of it, but its super annoying to be unable to navigate back to where I came from.

Comments not in correct sort

The comment order does not mirror what's happening on the site. This is frustrating as the top comment on the site has made it there through a lot of upvoting and downvoting whereas in the app it seems to be more random.
This makes it harder to get the value of the comment threads.

screen shot 2014-08-29 at 6 53 49 pm
screenshot_2014-08-29-18-53-21

Needs appcache

Since I'm using it as a web app on my phone, having appcache will greatly reduce the bandwidth cost.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.