Git Product home page Git Product logo

Comments (1)

zzstoatzz avatar zzstoatzz commented on September 9, 2024

hi @catermelon - thank you for the issue!

hmm I'm looking at this now - assuming all these pass, is this the behavior you would expect?

@pytest.mark.parametrize(
    "bucket_folder, path, expected",
    [
        (None, "", ""),
        (None, "file.txt", "file.txt"),
        ("prefix", "file.txt", "prefix/file.txt"),
        ("prefix", "/file.txt", "prefix/file.txt"),
        ("prefix/", "file.txt", "prefix/file.txt"),
        ("prefix/", "/file.txt", "prefix/file.txt"),
        ("/prefix", "file.txt", "prefix/file.txt"),
        ("/prefix", "/file.txt", "prefix/file.txt"),
        ("/prefix/", "file.txt", "prefix/file.txt"),
        ("/prefix/", "/file.txt", "prefix/file.txt"),
    ],
)
def test_resolve_path(s3_bucket, bucket_folder, path, expected):
    s3_bucket.bucket_folder = bucket_folder
    assert s3_bucket._resolve_path(path) == expected

or would you expect the leading / to remain?

from prefect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.