Comments (3)
Another workaround:
- prefect_docker.deployments.steps.build_docker_image:
id: build-image
requires: prefect-docker==0.6.0
image_name: "{{ prefect.variables.dp_test_project_image_name }}"
tag: latest
dockerfile: Dockerfile # added
additional_tags:
- "{{ get-commit-hash.stdout }}"
docker_push: &docker_push
- prefect_docker.deployments.steps.push_docker_image:
requires: prefect-docker==0.6.0
image_name: "{{ build-image.image_name }}"
tag: "{{ build-image.tag }}"
additional_tags: "{{ build-image.additional_tags }}"
With this the params to push_docker_image
and build_docker_image
are not the same, and they are not hiting eachothers cache it seems
from prefect.
Thanks for the bug report @mch-sb!
The intent of caching those steps is to avoid performing duplicate builds and pushes when deploying multiple flows, so you definitely shouldn't see cache hits between a build and a push on a single deployment. Your idea of including the function name in the cache key computation is great! Would you be up for submitting a PR making that change?
from prefect.
hi @mch-sb - thanks for identifying the issue here! the PRs above should fix this for 3.x and 2.x respectively, and will go out with the next release
from prefect.
Related Issues (20)
- Block types in 3.0 need to use 3.0 documentation links consistently HOT 1
- on_completion hook not running when task is cached in Prefect 2.x HOT 1
- Tests for prefect-ray and prefect-dask are failing
- CancellationCleanup service pegs CPU to 100%
- `prefect worker start --type ecs --pool batch --install-policy if-not-present` no longer works in prefect 2.x HOT 3
- Flow crashed HOT 8
- DbtCoreOperation `working_directory` argument does not work HOT 1
- Permission denied while creating temp folder for Gitlab refs (MacOs) HOT 4
- URLs in logs include trailing parentheses
- Tests in Github and Gitlab integrations should actually clone a repo
- Heterogeneous task compute resources
- URGENT: Prefect 2.20.5 Kubernetes Worker No Longer Passes Deployment Environment to Pod Environment HOT 6
- Issue during deployment run failure - 'Could not determine exit code for X' HOT 2
- Subflow with DaskTaskRunner with KubeCluster HOT 1
- retry_condition_fn Does Not Work With async Tasks in Version 3.x HOT 1
- prefect-aws doesn't calculate paths correctly if bucket_folder is set HOT 1
- Breaking Changes upgrading to v3.0 | GlobalEventLoopThread | prefect._internal.concurrency - Service 'EventsWorker' failed with 'n' pending items
- Migration from v2.2 to v3 breaks mypy typing of `my_flow.deploy()`
- Inconsistent `raise_on_failure=True` behaviour for `flow_run.state.result()` when using `run_deployment`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefect.