pramoneda / pdf-difficulty Goto Github PK

From the numpy documentation:

np.int was a deprecated alias for the builtin int. To avoid this error in existing code, use int by itself. Doing this will not modify any behavior and is safe. When replacing np.int, you may wish to use e.g. np.int64 or np.int32 to specify the precision. If you wish to review your current use, check the release note link for additional information.

This effectively causes a crash in

A regular int should be used here, I think.

In my dev environment, I experience an issue with ImageMagick due to the security policies they've added at one point: https://stackoverflow.com/questions/52998331/imagemagick-security-policy-pdf-blocking-conversion

Although that problem is unrelated with this code. What I found interesting is that I was still getting a True value from this function, although the command was crashing behind the scenes.

I think the return value of this function should be dependent on the return state of running that command.

Hey @PRamoneda! Unfortunately, I wasn't able to attend to ISMIR this year. However, it is great to see that your work made it to the program of this year :)!

Regarding this work, I was trying to run the example in the repo. After installing the initial requirements, I was getting an error due to librosa missing in my environment. It seems that you are using it in this module.

I was wondering if this dependency should be in the requirements.txt too?

Let me know if you would like to receive pull requests instead, I can maybe send a couple as I play with the code.

Great work, by the way! Thanks for making the code and preprint available. Greatly appreciated.