Ignore line or array specific key declaration about phpmnd HOT 7 OPEN

Hi @FlorentTorregrosa

Nope it is not possible to ignore a specific line of code in this moment.

from phpmnd.

Hi @sidz,

Thanks for the quick reply. Ok, so I didn't miss something :)

from phpmnd.

You can ignore every instance by using intval(10) instead of just 10. It's not ideal as you wouldn't know by looking at intval(10) that it's used to ignore a check for phpmnd.

Sounds a good feature request though :)

from phpmnd.

Yes and also it adds unneeded function calls.

I also tried to use string, the Drupal form API is enough permissive to do that, but I don't want to do that too. Typing is more and more enforced and changing the values type just to satisfy a code quality tool is a non-sense in my opinion.

Thanks for your feedback :)

from phpmnd.

Yeah agreed. I think the same about comments to ignore lines tbh. The array key whitelist is not a bad idea.

There is also a check in phpmnd for numeric strings which is good to enable as well. Which stops just hiding numbers by converting to a string

from phpmnd.

I like the feature to ignore specific array keys :) I see how it could be useful

from phpmnd.

I would love to add this tool to my default workflow but it runs against 30+ projects and being able to "exempt" individual lines would be absolutely crucial. The array keys bit is not a deal-breaker for me, especially since you could always do this:

$weight = 10; // @phpmnd-ignore-line
$data = [
    'weight' => $weight,
];

I would like to put forth a bounty on the line exemption comment feature - anyone willing to match? @exussum12 Can you provide a fair amount or expected time to implement?

from phpmnd.