What is "12" in Printer\XML ? about phpmnd HOT 5 CLOSED

It's funny that the lib that fights against magic numbers has really unclear magic number :)

from phpmnd.

It looks like a bug and should not be there imo.

@MacFJA can you confirm ?

from phpmnd.

Theres 1 more magic number detected as well, I will clean that up later this week

https://github.com/povils/phpmnd/blob/master/src/Printer/Console.php#L48
Printer/Console.php:48 Magic number: 2

48| $output->writeln(str_repeat(' ', 2 * self::TAB) . $hint);

Looking at the class it should be taking input from the console itself rather than just deciding whats best

from phpmnd.

It looks like a bug and should not be there imo.

@MacFJA can you confirm ?

Yeah, I see absolutely no reason for this + 12 to be here

from phpmnd.

I found that part a bit weird as well and refactored it in my fork. https://github.com/sidz/phpmnd/blob/master/src/Printer/Xml.php

unfortunately didn't have a chance to release a new version yet.

from phpmnd.