potproject / ikuradon Goto Github PK

もうDeprecatedなんだから移行しろ
https://reactnative.dev/docs/asyncstorage

そのまま https://github.com/react-native-community/async-storage でもいいけど
https://github.com/sunnylqm/react-native-storage がきっと楽、キャッシュ使えるし

https://github.com/potproject/ikuradon/blob/master/app/services/Networking.js#L9

このapi.urlを一回変数に入れてからいじらないと、2回目以降に:param:がreplaceされたやつをreplaceしようとしてしまって別のURLをたたいてしまう気がする

//(1回目) app.url = /api/v1/SOMEAPI/:params: → (2回目) app.url = /api/v1/SOMEAPI/REPLACED
api.url = restParams !== null ? api.url.replace(":param:", restParams) : api.url;
//app.url = /api/v1/SOMEAPI/REPLACED←これを保持してしまう(2回目以降置換するものがなくなる
                let response = await axios({
                    url: baseurl + api.url,
                    method: api.method,
                    headers: this.createHeaders(access_token),
                    params: Object.assign(api.form, postParams)
                });

Attaching APKs to releases/prereleases would be very helpful to let users try the app without building it from source :)

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Problem

React Navigation support for Redux integration is being depreacted.

Reference:
https://deploy-preview-193--react-navigation.netlify.com/docs/en/redux-integration.html

Some folks like to have their navigation state stored in the same place as the rest of their application state. Think twice before you consider doing this, there is an incredibly good chance that you do not need to do this!. Storing your React Navigation state in your own Redux store is likely to give you a very difficult time if you don't know what you're doing, and support for Redux integration is being depreacted.

In the next major version of React Navigation, to be released in Fall 2018, we will no longer provide any information about how to integrate with Redux and it may cease to work. It may continue to work either by coincidence or will of the community, but it will not be tested against or considered when making any design decisions for the library.

Solution

I think of 3 choose.

• Changing React Native Routing library
  I like to migrating React Native Router v4 / MobX
• Deleted Redux and replaced plain RN App
• Continue to support

案A: 消す(WebUIでも表示してない)
案B: 更新ボタンを作る

仕様上、お気に入りやブースト数のアップデートができない

onErrorをキャッチしてない、と言うのもPromiseにしてるとキャッチできない

https://github.com/potproject/ikuradon/blob/master/app/services/Stream.js
と言うかこの設計・・・Promiseだと無理やな
open -> this.ws[reducerType].onopen() -> resolveした後にこのPromiseはfulfilledまたはrejectedになり終了してしまうので
onerrorを当然察知することはできない、と言うかこんな使い方したらどんな挙動になるんだろう、気になる

WebSocketはReactであれば相性が良さげなので、onErrorやonCloseをReduxでDispatchしたほうが良いね、WebSockerを静的クラスのServiceとして使うのはちょっと無理ある

直そう

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.