popmednet-team / popmednet Goto Github PK
View Code? Open in Web Editor NEWThis is the repository for the open source code of the distributed data network platform PopMedNet
Home Page: https://www.popmednet.org/
License: Other
This is the repository for the open source code of the distributed data network platform PopMedNet
Home Page: https://www.popmednet.org/
License: Other
As part of openjournals/joss-reviews#4062, I am reviewing the installation instructions and have one request under the "Building PopMedNet" section:
Naming is a linux thing. No extension.
Right now the file links externally to another license. Best practice is that you have the link to the source but also include the text.
Paper is generally well-written and clear.
As part of openjournals/joss-reviews#4062 JOSS guidelines ask for "State of the field: Do the authors describe how this software compares to other commonly-used packages?" I do not see comparison to other used packages and software (i2b2/SHRINE, OMOP/OHDSI stack, Leaf, etc.) Could you please add in this background and comparison?
Minor suggestions:
As part of openjournals/joss-reviews#4062, I am running through unit tests and had multiple failures. The error is fairly consistent and descriptive:
Unable to create instance of class Lpp.Dns.DataMart.Model.QueryComposer.Tests.SummaryQueryTests. Error: System.Configuration.ConfigurationErrorsException: Unable to open configSource file 'ConnectionStrings.config'. (C:\Development\popmednet\Lpp.Adapters\Lpp.Dns.DataMart.Model.QueryComposer.Tests\bin\Lpp.Dns.DataMart.Model.QueryComposer.Tests.dll.config line 97).
I wanted to confirm (I did not see documentation on the README page) what setup steps are needed to run the unit tests. Are these more integration tests - requiring a full database setup, and setup of a configuration file?
As part of openjournals/joss-reviews#4062 JOSS guidelines ask for "State of the field: Do the authors describe how this software compares to other commonly-used packages?"
I do not see comparison to other used packages and software (i2b2/SHRINE, OMOP/OHDSI stack, Leaf, etc.) Could you please add this to the paper?
As part of openjournals/joss-reviews#4062, I am reviewing the installation instructions and had a few questions/requests for clarifications in the Required Software section:
Lpp.Adapters.sln
that it is targeting v4.8
. Should this reference 4.8 instead of 4.7.2? When I install 4.8 I don't get warnings.A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.