popmednet-team / popmednet Goto Github PK

As part of openjournals/joss-reviews#4062, I am reviewing the installation instructions and have one request under the "Building PopMedNet" section:

• For the final step (Login to PMN Portal as SystemAdministrator), could you please provide or add a link to where we can find the password for the SystemAdministrator (I was able to figure it out, but would like to have this easy to find for users).

Naming is a linux thing. No extension.

Right now the file links externally to another license. Best practice is that you have the link to the source but also include the text.

openjournals/joss-reviews#4062

Paper is generally well-written and clear.

As part of openjournals/joss-reviews#4062 JOSS guidelines ask for "State of the field: Do the authors describe how this software compares to other commonly-used packages?" I do not see comparison to other used packages and software (i2b2/SHRINE, OMOP/OHDSI stack, Leaf, etc.) Could you please add in this background and comparison?

Minor suggestions:

• "Provide protection of PHI" - could you please define PHI (with brief explanation/references, such as HIPAA Privacy Regs)? (line 52)
• References for FDA Sentinel and PCORnet (lines 64-65)

As part of openjournals/joss-reviews#4062, I am running through unit tests and had multiple failures. The error is fairly consistent and descriptive:

    Unable to create instance of class Lpp.Dns.DataMart.Model.QueryComposer.Tests.SummaryQueryTests. Error: System.Configuration.ConfigurationErrorsException: Unable to open configSource file 'ConnectionStrings.config'. (C:\Development\popmednet\Lpp.Adapters\Lpp.Dns.DataMart.Model.QueryComposer.Tests\bin\Lpp.Dns.DataMart.Model.QueryComposer.Tests.dll.config line 97).

I wanted to confirm (I did not see documentation on the README page) what setup steps are needed to run the unit tests. Are these more integration tests - requiring a full database setup, and setup of a configuration file?

As part of openjournals/joss-reviews#4062 JOSS guidelines ask for "State of the field: Do the authors describe how this software compares to other commonly-used packages?"

I do not see comparison to other used packages and software (i2b2/SHRINE, OMOP/OHDSI stack, Leaf, etc.) Could you please add this to the paper?

As part of openjournals/joss-reviews#4062, I am reviewing the installation instructions and had a few questions/requests for clarifications in the Required Software section:

1. "Visual Studio Professional 2019" - is Professional required? Or will Community work (I am using Community, will report back if any hard stops, but seems to be working so far)
2. ".NET Framework 4.7.2 Dev Pack" - I received a warning when loading Lpp.Adapters.sln that it is targeting v4.8. Should this reference 4.8 instead of 4.7.2? When I install 4.8 I don't get warnings.
3. "MVC4 from https://www.microsoft.com/en-us/download/details.aspx?id=30683." - the paper says it uses MVC5, not 4