polymarsdev / twini-golf Goto Github PK

I think you left out the source code license or forgot to choose one

Just came across your video on this - love it! High5 for the work and putting this together.

• Downloaded latest zip from Itch.io page
• Attempted to run binary
• Missing libgcc_s_seh-1.dll
• Missing libstdc++-6.dll
• Game execution halts there

• I'll attempt to build the source in something like Visual Studio to see if that helps? 🤷

How about a build system like GNU/Make or CMake?

The itch.io download has some dll's missing, more specifically:
libstdc++-6.dll
libgcc_s_seh-1.dll
You can find them at the bin directory of mingw64.

Edit: it works normally on pc's with mingw installed because the dlls are in the system path

So I compiled this on macos. And it immediately crashed after clicking to start a game.
However after some debugging I found the issue is your getStrokeText and getLevelText functions return a pointer to a std::string that is destructed in the function. A quick hack/fix for this, was to define them as globals so they stay in memory. Then the game works also on my macbook on catelina ;)

Here's the patch:

//reserve string in memory that does not get deleted
//as were returning char* from this!
std::string stroke_text="";
std::string level_text="";

const char* getStrokeText()
{
  stroke_text="";
	int biggestStroke = 0;
	if (balls[1].getStrokes() > balls[0].getStrokes())
	{
		biggestStroke = balls[1].getStrokes();
	}
	else
	{
		biggestStroke = balls[0].getStrokes();
	}
  std::string s = std::to_string(biggestStroke);
	stroke_text = "STROKES: " + s;
	return stroke_text.c_str();
}

const char* getLevelText(int side)
{
	int tempLevel = (level + 1)*2 - 1;
	if (side == 1)
	{
		tempLevel++;
	}
	std::string s = std::to_string(tempLevel);
	level_text = "HOLE: " + s;
	return level_text.c_str();
}

Another smaller issue was I was always getting a ttf error because the check did not work correctly.
This I patched as follows:

bool init()
{
	if (SDL_Init(SDL_INIT_VIDEO) > 0)
		std::cout << "HEY.. SDL_Init HAS FAILED. SDL_ERROR: " << SDL_GetError() << std::endl;
	if (!(IMG_Init(IMG_INIT_PNG)))
		std::cout << "IMG_init has failed. Error: " << SDL_GetError() << std::endl;
	if (TTF_Init()==-1){
		std::cout << "TTF_init has failed. Error: "<< TTF_GetError() << std::endl;
  }

  std::cout<<"Opening audio now!"<<std::endl;
	Mix_OpenAudio(44100, MIX_DEFAULT_FORMAT, 2, 2048);
	return true;
}

Ideally however you could better return a std::string or a smart pointer instead.

Now everything works except the sounds are not playing. But I do see its a nice game. Well done in 2 days ;).

Memory leaks are still a massive issue , within 60 seconds this program leaked 10+ gb of memory , thank god for swap

files.

mouse cant set ball power properly because of edge of screen maybe cursor needs to be set to false during shots ?

Should I add a static build workflow for linux? This would make it so people aren’t forced to install sdl themselves

i installed both sdl1.2 and sdl2 and get errors on all lines involving sdl
fatal error: SDL2/SDL_image.h: No such file or directory

The title says it all I guess.