Replace JsonMapper about pocketmine-mp HOT 6 OPEN

https://github.com/cuyz/valinor seems like a decent replacement

from pocketmine-mp.

https://github.com/cuyz/valinor seems like a decent replacement

After exploring the possibilities provided by this library :

1. The rewriting of JsonMapper -> Valinor works very well, the structure is practically the same with similar functions.
2. It is not possible to tag properties as optional unless you create a constructor with optional parameters for each class mapping (annoying).
3. Customisation and configuration seem simpler, allowing more things to be done
4. It isnt possible to deal with objet, only array or file is allowed.

The only current limitation I can see is the inability to tag properties as optional.

from pocketmine-mp.

It is not possible to tag properties as optional unless you create a constructor with optional parameters for each class mapping (annoying).

My understanding was that properties with default values are considered optional, am I wrong? AFAIK it should work pretty much seamlessly with the existing models (caveat: I have not tested)

from pocketmine-mp.

What i've tested is to create a constructor with all value at null by default. If its different than null, setting the properties.

I havent tested with direct default value in the properties.
The annoying side of this stay in the need to write all this constructor or default value in properties (which can cause unexpected bug if its set directly)

from pocketmine-mp.

I think the current JSON models already set default values for all optional stuff anyway, so it shouldn't be an issue.

I wouldn't worry about the constructor stuff. We don't manually construct the model objects anyway.

from pocketmine-mp.

I think the current JSON models already set default values for all optional stuff anyway, so it shouldn't be an issue.

Is it null ?

from pocketmine-mp.