plumatic / eng-practices Goto Github PK
View Code? Open in Web Editor NEWPrismatic's Engineering Practices
Prismatic's Engineering Practices
Howdy. Just wanted to suggest not promoting the use of :use
.
As of Clojure 1.4, require
serves both its original purpose and the purpose of use
via the :refer
modifier. For example
(ns foo.bar.baz
(:require [plumbing.core :refer :all]))
If compatibility with pre-1.4 is not a requirement, this is generally a better way to go. It makes ns
declarations far more consistent and uniform, and also means there is less code using use
if it gets deprecated at some point in the future (which would not be entirely unsurprising).
My suggestion would be to replace the use
uses (no pun intended) with require
, but add a note about use
for the unlikely event that the reader requires < 1.4 compatibility.
As a secondary thing, it isn't really great to promote these unqualified imports. In tests and such it is generally fine, but in actual code you almost always want to qualify things for readability and clarity. It seems to be trying to say this, but it doesn't feel clear enough. I'd be more aggressive in saying that it's almost always a bad idea to do unqualified imports. I don't know what plumbing.core
is and whether or not it is a good example of an exception though.
Cheers!
In the git guide, you mention ppull, is this a special esoteric tool or just a typo?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.