Git Product home page Git Product logo

room's Introduction

Room Management plugin for GLPI

This is a plugin to add room management feature to GLPI assets inventory software.

Description

This plugin allows you to manage the rooms and the elements that are included in. A room is not the same as a location that already exists in GLPI because it can not contain items nor be loaned (which a room can be).

GLPI 9.5.1 compatibility added and tested. Translation fixed (gettext domain). I also added a basic hungarian translation :)

Installation

This plugins installs as any other GLPI plugin.

  1. Place the current source code tree in a directory named room and move this one inside the plugins directory of your GLPI installation.
  2. Go to Setup > Plugins.
  3. Look for the Room Management plugin's row.
  4. Click on the Install button.
  5. Click on the Enable button.

Uninstallation

This plugins uninstalls as any other GLPI plugin.

  1. Go to Setup > Plugins.
  2. Look for the Room Management plugin's row.
  3. Click on the Disable button.
  4. Click on the Uninstall button.
  5. Delete the plugins/room directory of your GLPI installation.

Contributing

Please follow the following rules for contributing:

  • Respect PSR-1 and PSR-2.
  • Open an issue for each bug/feature so it can be discussed.
  • Follow development guidelines.
  • Refer to GitFlow process for branching.
  • Work on a new branch on your own fork.
  • Open a PR for merging. It will be reviewed by a developer.

Coding standards

Respect of coding standard is checked by PHP Coding Standards Fixer. The .php_cs.dist file contains the standards to conform to.

Command to list all PHP files with standard issues:

php php-cs-fixer-v2.phar fix --config .php_cs.dist --dry-run.

Same command but includes detail of actual lines with standard issues:

php php-cs-fixer-v2.phar fix --config .php_cs.dist --dry-run --diff .

Command to fix thoses issues:

php php-cs-fixer-v2.phar fix --config .php_cs.dist .

room's People

Contributors

bogucool avatar c-duv avatar eskiso avatar jackburton79 avatar lukacspeter avatar milotype avatar remicollet avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

room's Issues

Fail in setup

The plugin fails in GLPI 9.5, and I can't run this!
The message with fail is:
Notice: Undefined index: plugin_room in C:\xampp\htdocs\plugins\room\setup.php on line 46

Version GLPI 9.4.0 ou autre plugin

Bonjour,

Je voulais savoir s'il existait une version de Room compatible avec GLPI 9.4.0 ?
Sinon, existe-t-il un plugin permettant de faire de la gestion de salle ?

D'avance merci
Cordialement,

Allow opening/linking tickets to rooms

It would be useful if opening tickets on (or linking existing ticket to) room was possible: this would allow helpdesk to handle users' issues with room.

GLPI 9.4 Compatibility

Please, would you update the plugin to support GLPI 9.4 Thanks. Is a very usefull plugin. thanks.

Computer associate a room

Please, on a 9.3.1, i installed room plugin evol 9.3.1.

I can create room but i cannot see how assocaite computers with a room.
I have an experimentation with a clean install : same result.
Where can i found inforamtion to resolve thi ? I am ready to contribute to a tutorial for this.
Thanks,

9.3.1/3.1.2alpha: sql error reported:

Installing works fine, but enabling shows this error:

[2019-01-24 13:22:40] glpisqllog.ERROR: DBmysql::query() in /usr/share/glpi/inc/dbmysql.class.php line 177
*** MySQL query error:
SQL: SELECT *
FROM glpi_profilerights
WHERE profiles_id 4
AND name LIKE "%plugin_room%"
Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '4
AND name LIKE "%plugin_room%"' at line 3
Backtrace :
inc/dbmysqliterator.class.php:95
inc/dbmysql.class.php:580 DBmysqlIterator->execute()
plugins/room/inc/profile.class.php:195 DBmysql->request()
inc/plugin.class.php:800 PluginRoomProfile::initProfile()
front/plugin.form.php:47 Plugin->activate()
{"user":"[email protected]"}

Convert translations to new format

In Glpi 9.5 the old php locale format was deprecated in favor of gettext's po/mo format.
Only Italian and Hungarian translations of the room plugin have been converted for now, while Deutsch, Francais, Portuguese translations haven't yet been converted.

Create proper README file

Current README file is 8 years old and only contains changelog informations.
A proper README file explaining the plugin and how to install, develop might be (more) useful.

Remove support for old GLPI versions

Currently, the code is bloated with lots of if/variants to support various GLPI versions (I am not even sure this support is reliable).

As stated in 6f9eed9, compatibility with GLPI versions older than 9.1 will be dropped.
This will allow some code removal and pave the way for some future improvements.

Disclaimer: not being the original author of this plugin I don't really understand it fully (nor took the time to though), but I guess that cleaning it and using state-of-the-art GLPI methods will help me know it better.

Rooms disappeared

When trying to add some more fields on global view all the rooms that i had disappeared but not deleted from the database. I checked and they are still there. There was no sing of any error, they just disappeared.

GLPI 9.4.4
room 3.1.2

Cant find setup

Added the room directory to /glpi/plugins/room yet it still doesn't show up in the plugins menu

glpi version: 9.5.3
room version: 3.1.3

problem with "room" and "reservation" plugins

hi, when I use Room plugin with the Resertvation plugin, there is an error when I click directly on one room object (not if I select it) : there is a redirection to /glpi/front/pluginroomroom.form.php wich does not exist. I think it comes from a bad item identification in the Room plugin. Maybe this is not the case (I am not developper :-( )

Best Regards

Reservations are not removed on uninstallation

When uninstalling the plugin, reservations of rooms are not removed.
This causes issues when re-installing the plugin as newly created room IDs start at 1 which will eventually collide with IDs of prior plugin installation (which also started a 1), A newly created room could be already linked to several old reservations.

reservation display

Hello,
I would like to know if it is possible to display the purpose of the meeting rather than the name of the person who reserved the room.

Thank you for your help


Bonjour,
Je souhaiterai savoir s'il est possible d'afficher l'objet de la réunion plutot que le nom de la personne ayant reserved la salle.

Merci de votre aide

Sort by week ?

Hello,

We are testing this plugin for our school, and I was wondering if there was a way to have one display per week ? And maybe one by day ?

And is there a way to show one room schedule for Public ? Without needed to connect on GLPI.

Thanks in advance.

Compatibilité Glpi 5.1

Bonjour,
J'utilise GLPI 5.1 et je veux pouvoir ajouter la réservation de salles pour ls utilisateurs, j'ai vu qu'il y avait déjà une demande concernant la version du glpi 9.5 mais je souhaite savoir si une version plus à jour est sortie, j'ai essayé d'installer l'autre version mais il m'indique que j'ai un problème avec le fichier "hook.php" dans les les 290 à 300.

Merci, bonne journée

GLPI 9.2

I tried it in GLPI 9.2.

I viewed the source (room.class.php). The form rendering is incorrect, because in debug mode wrote this error message:
"Fatal error: Call to undefined method Dropdown::showInteger() in /var/www/html/glpi/plugins/room/inc/room.class.php on line 315"

Dropdown::showInteger("size", $this->fields["size"],0, 500);

[Request] GLPI 9.3 compatibility

They have just released GLPI 9.3 beta and I don't know if this might break compatibility with the current plugin version.
Please, would you update the plugin to support GLPI 9.3 in its final stable version?

Thank you in advance.

GLPI 9.5 compatibility

Hi,
GLPI 9.5.0 is almost out (there is a rc2).
The rooms plugin does not work with this version.
I've started working on a branch to adapt the code to the newest GLPI api.

https://github.com/jackburton79/room/tree/glpi_9.5_compatibility

here's the PR: #45

At the moment I'm testing the modified room plugin on GLPI 9.5.0rc1 and it seems to work, except for some issues:
I had to disable translations, for now, since the code needs to be adapted to use gettext.
I can create a PR, but I see the previous PR (for glpi 9.4.0) wasn't integrated.
Thanks for your work!

SQL errors when uninstalling the plugin

When uninstalling v3.0.4b2 of the plugin, sql-errors.log is filled with SQL errors complaining about tables it cannot find:

*** MySQL query error:
SQL: DROP TABLE `glpi_plugin_room_rooms_computers`
Error: Unknown table 'glpi_plugin_room_rooms_computers'
Backtrace :
plugins\room\hook.php:355                          
inc\plugin.class.php:639                           plugin_room_uninstall()
:                                                  Plugin->uninstall()
front\plugin.form.php:49                           call_user_func()

Tables are:

  • glpi_plugin_room_rooms_computers
  • glpi_plugin_room_roomtypes
  • glpi_plugin_room_roomaccessconds
  • glpi_plugin_room_dropdown1s
  • glpi_plugin_room_rooms

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.