plugily-projects / minigamesbox Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 14.0 16.08 MB

Minigame methods used by us combined into one core to get a overall unified structure

Home Page: https://plugily.xyz

License: GNU General Public License v3.0

Java 100.00%

minecraft spigot

minigamesbox's People

Contributors

Stargazers

Watchers

Forkers

verschuerentom montlikadani fredthedoggy flaimer2 mc-dreamland mathsanalysis youapipe shallowai plajer epicjosch waterman1001 frafol jiternos

minigamesbox's Issues

NPE from MiniGamesBox when starting BuildBattle 5.0.2 on Paper 1.20.4.

NPE starting BuildBattle 5.0.2 on Paper 1.20.4.

[16:59:18 ERROR]: Error occurred while enabling BuildBattle v5.0.2 (Is it up to date?)
java.lang.NullPointerException: Profile name must not be null
        at java.util.Objects.requireNonNull(Objects.java:233) ~[?:?]
        at com.mojang.authlib.GameProfile.<init>(GameProfile.java:31) ~[authlib-6.0.52.jar:?]
        at plugily.projects.buildbattle.minigamesbox.classic.utils.helper.ItemUtils.getSkull(ItemUtils.java:67) ~[buildbattle-5.0.2.jar:?]
        at plugily.projects.buildbattle.handlers.menu.registry.playerheads.PlayerHeadsRegistry.registerCategories(PlayerHeadsRegistry.java:65) ~[buildbattle-5.0.2.jar:?]
        at plugily.projects.buildbattle.handlers.menu.registry.playerheads.PlayerHeadsRegistry.<init>(PlayerHeadsRegistry.java:54) ~[buildbattle-5.0.2.jar:?]
        at plugily.projects.buildbattle.handlers.menu.OptionsRegistry.registerOptions(OptionsRegistry.java:79) ~[buildbattle-5.0.2.jar:?]
        at plugily.projects.buildbattle.Main.initializePluginClasses(Main.java:105) ~[buildbattle-5.0.2.jar:?]
        at plugily.projects.buildbattle.Main.onEnable(Main.java:84) ~[buildbattle-5.0.2.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:281) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:190) ~[paper-1.20.4.jar:git-Paper-364]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104) ~[paper-1.20.4.jar:git-Paper-364]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugin(CraftServer.java:637) ~[paper-1.20.4.jar:git-Paper-364]
        at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugins(CraftServer.java:548) ~[paper-1.20.4.jar:git-Paper-364]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:673) ~[paper-1.20.4.jar:git-Paper-364]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:433) ~[paper-1.20.4.jar:git-Paper-364]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:308) ~[paper-1.20.4.jar:git-Paper-364]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1132) ~[paper-1.20.4.jar:git-Paper-364]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321) ~[paper-1.20.4.jar:git-Paper-364]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Looks like this is caused by name being set to null on line 67 in ItemUtils#getSkull

Proposals for changes in Locale & Language Manager

First way

Load the locale defined in config.yml from the cloud as a Properties. If the locale is not found, load the default locale (English)
Put the key-value pairs of the Properties to language.yml
The plugin will use language.yml to get & set messages

The users have full control of the language, and if there is a change in the messages, we can just update it in language.yml.
The drawback is that they must remove language.yml and let the plugin refresh it if they want to get the updated translated messages or change the locale.

Second way

Load the locale defined in config.yml from the cloud as a Properties. If the locale is not found, load the default locale (English).
Store the Properties in a temporary location.
language.yml is empty & only contains overridden strings for the Properties.
When getting a message, the plugin first check if there is a path in language.yml. If it's found, load it; otherwise, get the message in the Properties.

language.yml is smaller in file size as it only contains the replacement of the messages in the locale file. If there is a change in the messages, we can simply update the locale file.
The drawback is that the users have to find the correct path to set in language.yml if they want to replace a line.

Combine normal & paged FastInv into one abstract library

That way the code will be less duplicated & easier to be maintained.

VersionUtils.teleport() Paper Server async problem.

I have no idea why the code of teleporting for paper servers is async, howerver, it generates the bug that special items that should be updated into the player's inventory after the teleporting code don't show up when it comes to multiverse. The async codes make the inventory updating too early due to the gap of dimension changing. So if there's no special reason for keeping async for paper servers (the only reason comes to my mind is the optimization), just simply clean the code: if(isPaper){...} and only use entity.teleport(location);

plugily-projects / minigamesbox Goto Github PK

minigamesbox's People

Contributors

Stargazers

Watchers

Forkers

minigamesbox's Issues

NPE from MiniGamesBox when starting BuildBattle 5.0.2 on Paper 1.20.4.

Proposals for changes in Locale & Language Manager

First way

Second way

Combine normal & paged FastInv into one abstract library

VersionUtils.teleport() Paper Server async problem.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent