plctlab / riscv-operating-system-mooc Goto Github PK

Hi,
我正在尝试使用Rust实现RVOS。在实现第13章抢占式多任务的时候，在task_yield()中调用r_mhartid()导致 illegal instruction ，通过调试发现是csrr $0, mhartid这条指令导致的异常。 应该是与csrr这个指令有关，因为在测试csrw的时候也不行。
我的代码在这：https://github.com/RobotHuang/rvos-rust/blob/master/os/src/sched.rs#L145
Thanks

Hi there!

關於外部中斷，我有一些疑惑，還望各位指教，在介紹第 11 章的外部中斷時，提到了我們可以對 PLIC 設置外部中斷做到 UART 輸入的功能，針對這個地方，我有兩點疑問:

1. 我參考這一資訊，將外部中斷的處理方式移植到了 mini-riscv-os 上，但是我發現即使不在 OS 開機時也能使用 UART 輸入，想請問我是不是遺漏了什麼重要觀念
2. 呈上題，如果不開啟外部中斷也能使用 UART 輸入，那在什麼情況下才會產出 IRQ = 10 的情況呢?

謝謝。

System environment:

Distributor ID: Ubuntu
Description: Ubuntu 22.04.4 LTS
Release: 22.04
Codename: jammy

GNU Make

GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Error

Makefile:1: *** missing separator. Stop.

Troubleshooting process

I found that the Makefile files in all folders under asm do not use standard universal syntax, like this:
../build.mk

There may be some versions that can support such writing, but there is no doubt that it is not supported on my system. I tried updating make, but it did not work. The general and correct writing should be as follows:
include ../build.mk

After making the changes it started working without a doubt

Ending

Correspondingly, I have sent a PR, I believe it will work well on any make version