planetdecred / godcr Goto Github PK

The wallet page has a main layout method "WalletPage" which returns the entire layout of the page. The method is passed a "PageCommon" data type as an argument and added to a map of all pages.

The receive page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page
• Use the page "Layout" method to display the page within the navigation tab
• Have and handle it's own tab of wallets
• Have an on-page modal that handles account selection

Describe the bug

the restore page starts to flicker when I scroll the inputs without click

To Reproduce

Steps to reproduce the behavior:
On the restore page, type in an input field, when the suggestion input is displayed, scroll the row of inputs.

Expected behavior

Page should display without flickering

Actual behavior

Page flickers

Relevant screenshots or logs

Describe the bug

When syncing wallet, could not create new wallet

To Reproduce

Steps to reproduce the behavior:

• On page create wallet
• When I click on create new wallet

Expected behavior

When syncing wallet should disable button add wallet from wallet page

Relevant screenshots or logs

2020-05-30 16:57:38.264 [ERR] UI: Wallet Error: Could not create wallet : sync_already_in_progress
2020-05-30 16:57:38.614 [INF] CMGR: DNS discovery failed on seed x5.testnet-seed.decred.netpurgatory.com: lookup x5.testnet-seed.decred.netpurgatory.com: no such host

The verify message page should:

Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
Have a "Handle" method that handles the events on the page

Feature description

These are the required improvements for the current tab implementation

• make it similar in design to the tab.go in the example.
• add icon support for the tab widget for use as a navigation tab
• option to change alignment to left or top
• the same widget should be usable both as the navigation tab and for pages that use tabs like the wallets, transactions, receives and send pages.
• add a physical scroll button for horizontal scrolls. Desktop users using physical mouses or laptop users without trackpad gestures might not be able to scroll horizontally when the tab width exceeds the window size.

Additional context

Current Design

Mobile Design (target design)

Tabs.go (Gioui Example)

Tabs.go (modified Gioui Example)

Tab scroll button (screenshot from material.io)

Describe the bug

Godcr-gio does not build

To Reproduce

Steps to reproduce the behavior:
Run go build on terminal

Expected behavior

go build should build the required executable

Actual behavior

go build errors

Platform

• Linux

• Linux

• MacOS

• Windows

Relevant screenshots or logs

Error logs

# github.com/raedahgroup/godcr-gio/pages/wallet pages/wallet/create.go:71:47: too many arguments in call to w.multiWallet.MultiWallet.CreateNewWallet have (string, string, number) want (string, int32) pages/wallet/restore.go:88:45: too many arguments in call to w.multiWallet.MultiWallet.RestoreWallet have (string, string, string, number) want (string, string, int32)

Can the feature be described as a User story?

When I'm on the "restore existing wallet" page, I should be able to:

• input all my wallet seed
• input my spending password
• restore my wallet after confirming my wallet seed and spending password
• input my spending pin
• create a spending pin for my restored wallet

Additional context

Mobile mockup

Describe the bug

The copy button for copying the receiving address on the receive page stops working when the page layout is shrinked/reduced.

If not, decribe the feature

Currently, wallet and account selection is displayed to the left of the page. Wallet options is displayed with buttons on a tab separate from the page that needs it. This is not a clean design.

This should be improved by adding an account selection dialog widget that can be called by any page that needs it. Upon selection, the selected wallet and account should be passed to the caller as opposed to setting them on the app window itself

The wallet page has a main layout method "WalletPage" which returns the entire layout of the page. The method is passed a "PageCommon" data type as an argument and added to a map of all pages.

The transaction page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page
• Use the page "Layout" method to display the page within the navigation tab
• Have and handle it's own tab of wallets

Describe the feature

*create a custom editor with a "paste and clear" feature. There should be an option to display or hide the paste button next to the editor. A similar feature was implemented on PR #69

• add a line beneath the editor

Additional context

screenshot of the verify message modal.

screenshot of material editor from materializecss.com

Describe the bug

I get this error after running go build on godcr:
xkbcommon: ERROR: couldn't find a Compose file for locale "en_NG"
xkbcommon: ERROR: couldn't find a Compose file for locale "en_NG"

Expected behavior

Running go build should start the UI frontend

Actual behavior

After running go build execution continues but no view is displayed

Platform

GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/sam/go"
GOROOT="/opt/goSDK/go1.14.3"
GOTOOLDIR="/opt/goSDK/go1.14.3/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"

Relevant screenshots or logs

If not, describe the feature

Read configuration from the command line arguments.

Additional context

Currently, configuration is only read from the default config file.

Looked more at that full screen crash I was getting. Seems to occur when resizing to larger then 2000x2000px. I have confirmed this on linux. No further error log about the crash has been found, even with log trace.

Describe the bug

When a modal on a page is active, intractable widgets can be clicked

To Reproduce

navigate to the sign message page and attempt to sign a message. When on the password modal pops up, click the sign button.

Expected behavior

I shouldn't be able to click the sign button when the modal is active.

Actual behavior

button behind the modal responds to a click event.

If not, decribe the feature

Replace rounded cancel button with simple cancel icon button. (cancel button should be gray not red)

Additional context

rounded button in top right corner.

Use a custom gio theme derived from the existing material widgets theme.

The sign message page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page

When we're on Overview page, click to transaction will open Transaction details page

Related #63

describe the feature

Currently, the wallet "send" channel receives an interface. This makes it a little difficult handling errors since all data types are sent to the same channel.

The wallet page has a main layout method "WalletPage" which returns the entire layout of the page. The method is passed a "PageCommon" data type as an argument and added to a map of all pages.

The send page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page
• Use the page "Layout" method to display the page within the navigation tab
• Have and handle it's own tab of wallets
• Have an on-page modal that handles account selection

The wallet page has a main layout method "WalletPage" which returns the entire layout of the page. The method is passed a "PageCommon" data type as an argument and added to a map of all pages.

The Overview page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page
• Use the page "Layout" method to display the page within the navigation tab

There should be an option on the editor widget for masking the input when typing into the editor. This has been implemented by @codemaestro64 and pushed upstream. Prior to the time it gets merged, we can have it on our branch.

Can the feature be described as a User story?

Given that I'm on the wallets page and I have wallets already created, I should be able to

• see and click a button to show me a dialog to sign a message for each wallet.
• sign a message.

Additional context

Mobile Mockup
Add any other context about the problem here.

Currently most widgets live in Window.inputs or Window.outputs and this has gotten quite cumbersome ( Window.handleinputs is also very long as a result).
This need to be improved.

Can the feature be described as a User story?

Given that a wallet has been created or restored.
When I’m on the send page, I should be able to:

• input the address I want to send DCR to
• input the amount I want to send in DCR and see it’s USD equivalent
• see the transaction fee
• see the total number of DCR I’ll be sending which includes transaction fees and my balance after a successful transaction
• see a confirmation page or popup modal asking me to confirm my inputs before sending DCR

Additional context

Mobile mockups

confirmation modal

Add the create account feature to the new wallet layout.

Describe the bug

Each time the "GetMultiWalletInfo" wallet command is called, it returns the list of wallets in a new order. This affects pages using the list as it also makes dependent UI components rendered randomly as well.

To Reproduce

Steps to reproduce the behaviour:
When syncing wallets, in the wallet details section, observe the order of the wallet cards.

Expected behaviour

The order of the wallet detail cards shouldn't change at any point of the sync

Actual behaviour

The order of the wallet detail card should be the same through out the sync process in an increasing order of their wallet IDs

Can the feature be described as a User story?

Given that I'm on the transactions page and I have made some transactions, I should be able to

• click on each transaction and view details about the transaction
• click a text that redirects me to view more details about the transaction on dcrdata

Additional context

Mobile mockup

the feature

States should be automatically updated when a wallet event is triggered.

Can the feature be described as a User Story?

Given that I'm on the wallets page and I have wallets already created, I should be able to

• see and click a button to show me a dialog to verify a message for each wallet.
• verify a message.

Additional context

Mobile mockup

Can the feature be described as a User story?

Given that I have created or restored a wallet
Whenever I launch the app
Then I should see an "Overview" page containing some recent transactions
And I should see my total balance
And I should see the status of the wallet

Additional context

Mobile mock up.

Can the feature be described as a User story?

Given that a wallet has been created or restored
When I’m on the transactions page, I should be able to

• see a list of transactions from my wallet if I have any or an empty page if I have none.
• sort them by newest or oldest
• view all of them at once or filter them by received, sent or transfer

Additional context

Mobile Mockup

describe the feature

Currently gio doesn't directly support svg images but it can work with iconvg. To do that, we need to be able to convert svg images to iconvg images.

Additional context

Add any other context about the problem here.

Describe the bug

When a wallet event is triggered, the wallet state should be updated automatically

Can the feature be described as a User Story?

Given that there are no detected wallets on the system
When I launch the application
Then I should see a "Landing" page
With a "Create Wallet" option
And a "Restore existing wallet" option

Additional Context

Here's the mock up for the android mobile wallet.

If not, describe the feature

Godcr needs a navigation bar. A means through which a user can switch available pages within the app.

Additional context

Navigation bar from mobile Mockup.

Since this is a desktop application, however, the navigation bar could be on the left vertically rather than at the bottom horizontal as on the mobile app.

Can the feature be described as a User story?

Given that I'm on the wallets page and I have wallets already created, I should be able to

• see and click a button to show me a dialog to change my wallet spending password.
• change my wallet spending password.

Additional context

Mobile Mockup for change spending password

Can the feature be described as a User story?

When I'm on the "wallets" page, I should be able to:

• see a list of all my existing wallets and accounts under each wallet
• click on a wallet and see its details
• rename an existing wallet
• delete an existing wallet.

Additional context

Can the feature be described as a User story?

Adds support for tabcontainer support for trailing, leading, top and bottom layout.

The wallet page has a main layout method "WalletPage" which returns the entire layout of the page. The method is passed a "PageCommon" data type as an argument and added to a map of all pages.

The "create and restore wallet" page should:

• Have a main layout method which is also passed the common data type an argument and any other data type that might be needed in the page.
• Have a "Handle" method that handles the events on the page

Can the feature be described as a User story?

When I open page the "create and restore" wallet page, I should be

• see two buttons one to create wallet and the other for restore wallet
• I should be able to access this page from the wallets page
• I should also see this page when I have a no wallets

A feature with the same goal was worked on in PR #22

Additional context

Mobile mockup

Can the feature be described as a User story?

When I open page the sign message or verify message pages from the wallet page, I should see a back button I can click that takes me back to both pages.

Can the feature be described as a User story?

If wallets do not exist open wallet creation page

Additional context

Add any other context about the problem here.

Separate pages into self contained structs.

Each page should have an init function outside the window draw loop that initializes it's widgets. Each page should also have a reset or on close function that is called to reset page state when the page is navigated away from.

If not, decribe the feature

They are used on the transaction details page to expand details of a transaction that a user might only need to see occasionally. Currently there's an implementation on Transaction Details PR #72 to fulfil this purpose, however, a widget would make the implementation cleaner.

Additional context

Implementation on PR #72

Mobile Mockup

Can the feature be described as a User story?

When I'm on the "create new wallet" page, I should be able to:

• input my spending password
• input my spending pin
• create a new wallet after confirming all my credentials

Additional context

Mobile mockup

Can the feature be described as a User story?

Given that a wallet has been created or restored.
When I’m on the receives page, I should be able to:

• see a wallet address for one of my wallets that I can receive DCR with.
• see a QR code for the displayed address which can be scanned to receive DCR into my wallet.
• easily copy the wallet address by clicking the displayed address

Additional context

Mobile mockup

describe the feature

To show the level of completion of a process, a progress bar is needed. It should be added to the custom material theme.

Additional context

Progress bar from overview page.

Migrate the change password page to the new project layout.