Git Product home page Git Product logo

Comments (3)

arthurzam avatar arthurzam commented on July 19, 2024

After checking the code, it indeed doesn't work currently. The current logic is that maintainer-needed packages have maintainers as empty tuple.

Do you prefer the return of --maintainer-needed, or that --maintainer maintainer-needed will work? I think the first one is better, but implementation wise there isn't a lot of difference.

from pkgcore.

thesamesam avatar thesamesam commented on July 19, 2024

I think I prefer --maintainer maintainer-needed for consistency, but it's not a strong feeling.

from pkgcore.

arthurzam avatar arthurzam commented on July 19, 2024

I think I prefer --maintainer maintainer-needed for consistency, but it's not a strong feeling.

OK, this will be the way I do it. Fun fact, we have something there already, when empty value is passed, it checks for maintainer needed: https://github.com/pkgcore/pkgcore/blob/master/src/pkgcore/scripts/pquery.py#L782-L786
But I will still add this case, as it makes it clearer

from pkgcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.