pixmob / httpclient Goto Github PK

Very often when you receive 4xx or 5xx codes you need to check the response content to find out what went wrong, but currently you only read inputstream when isStatusCodeError(statusCode) is false.

A network request is sent: expected status codes contains 404.
When the response is read with a status code 404, the error HttpClientException is raised, followed by a FileNotFoundException. As 404 was expected, this error should not happen.

Although the defaults make a lot of sense, sometimes a server doesn't play nice and you need to set a specific content encoding and character set to be accepted. For example, teh webserver I am talking to claims to support gzipped content, but often returns scrambled data when I ask for it.

I suggest keeping the defaults in place but allow setting of content encodings and charset on the HttpClient, so these settings are used in any successive http request.

Library does not support cache because it set conn.useCache(false) in HttpRequestBuilder.execute method

There should be a property and a getter for response so that I can check the response without using the handler. In some cases it's more convenient NOT to use handler. e.g. AsyncTask where you want to return the response in the doInBackground() method. It's good to make things flexible.

httpclient includes a fix for a bug in Android's HttpURLConnection before Gingerbread such that headers are converted to lowercase. However, HttpRequestBuilder's cookie parsing does not handle such cases, where the cookies header is "set-cookies" instead of "Set-Cookies". (The returned HttpResponse has them properly set as "Set-Cookies" header, but then the parsing into in-memory cookies already failed.)