Bug: WEBGL: INVALID_VALUE: shaderSource: string not ASCII (Older chrome version) about pixijs HOT 6 CLOSED

hey there! thanks for sharing the issue. I have a few questions for ya that would help me to understand what might be going on.

• is this the exact code that does not compile?

• which chrome version are you using?

• is it a consistent error?

• if you could create aplayground demonstrating the issue that would be ace!

Thanks in advance!

from pixijs.

Hi @GoodBoyDigital, I'll try to answer:

• yes, this is the exact code
• Chrome 68 (yes it's old, I'm using PIXI in the app for LG TVs, and 2020 models are based on Chrome 68)
• Yes it's consistent
• Will do

from pixijs.

good to know thanks!

from pixijs.

Hi @GoodBoyDigital, here you can see the error:
https://beta.zima.pages.dev/test/onecard

I wasn't able to do it in any of the public editors since they seems to not support chrome 68 anymore, but I did not minify JS for my example, you can clearly see where the error is happening.

from pixijs.

Hi @GoodBoyDigital , I found the issue, it's the comment string which Chrome 68 incorrectly interprets (it's the "'" character):

// This checks if it's WebGL1

When I removed the comment form shader source, shader compiles correctly.
We can replace it with "it is" I suppose :)

from pixijs.

I created a tiny PR for this change:
#10320

Feel free to adapt it on your own if necessary

from pixijs.