pixeltopic / wayfarer-2-server Goto Github PK

I currently have everything as just a number by itself (eg 400, 403, 401...)
This is bad. See https://en.wikipedia.org/wiki/Magic_number_(programming)

I have already begun refactoring it by using the HttpStatus package.

Add it as a key in dev.js and prod.js, but on prod make sure it says false.

Remove all console.logs and replace them with winston.logger.

Bad coding practices return to haunt me

Using a deprecated package. Migrate to this instead https://www.npmjs.com/package/bcrypt

Use joi to validate schemas of incoming post requests to simply validation logic.

Proposal: Make page token search its own endpoint to prevent schema complications.

As stated in Node Best Practices, centralized error handling should be used. While I think the complexity of the app does not yet warrant a dedicated object, it would be good practice to implement a middleware that catches all errors.

Use something like mocha and chai to write tests to ensure endpoint behavior is working properly

Some project structure choices are unsatisfactory. Before beginning the next round of endpoints for registered users, refactor these (This link provides a good guideline and frame of reference):

Issues include (but are not limited to):

• Move IncidentsProcessor out of /utils and into /services
• Create a DB Data Access interaction layer (Similar to repositories convention in golang project structure)
• MapWrap interactions with the Google API should also be abstracted into functions within a new file in /services to simplify code.

refreshedToken should be renamed to token, and should always return either the currently valid token or a refreshed token. The frontend will update the token on each call. The refreshed or current auth token should be sent in res.locals instead of req.auth.