pilzadam / farming_plus Goto Github PK

"I've introduced a new maize (corn) plant with corn cobs to the mod. This expands the available plant variety."

2016-11-26 17:29:45: ACTION[Server]: BarrBarr uses farming:hoe_diamond, pointing at [node under=16002,5,16031 above=16002,6,16031]
2016-11-26 17:29:45: ERROR[Main]: ServerError: Lua: Runtime error from mod 'farming' in callback item_OnUse(): ...Minetest\bin..\games\minetest_game\mods\farming/api.lua:92: attempt to call field 'hoe_on_use' (a nil value)
2016-11-26 17:29:45: ERROR[Main]: stack traceback:
2016-11-26 17:29:45: ERROR[Main]: ...Minetest\bin..\games\minetest_game\mods\farming/api.lua:92: in function <...Minetest\bin..\games\minetest_game\mods\farming/api.lua:91>

Yes, I've tried this mod. Hmm. Not enough farming. Needs more farm. Thank you.

atm, the code doesn't check for anything under the seed, you could even place one plant above another

it should be done like the farming mod, check if where the player is soil

https://github.com/minetest/minetest_game/blob/master/mods/farming/init.lua#L274-327

I have modified a bit textures for carrots for match a bit better minetest defaults colors see if you like it

Edit

Added potato

and orange

Hi,
Currently, wheat seed can not be planted in minetest 0.4.10.
This has already been reported on the forum:
https://forum.minetest.net/viewtopic.php?p=147231#p147231

I have installed the most recent master of farming_plus (downloaded the zip from here), and i have great trouble finding wild crops, like carrots, potatoes, etc. I have meticulously searched a 1500x1500 (or larger) area, but have found only 2 potatoes and a tomato.
I'm using the base texture pack, and the the most recent minetest nightly, which at the moment of this writing is 0.4.10-135-gd1ccc64-dirty
Below is a list of my mods. All nature- and mapgen-related mods are checked and are up-to-date as of october 12th, 2014.

3d_torch
advanced_market
arrow_signs
awards
bakedclay
bamboo
beds
bitchange
boats
bones
bridges
bridgetool
bucket
carpet
carts
channels
charcoal
chatplus
coloredwood
colormachine
colouredstonebricks
columnia
connected_textures
cottages
creative
datastorage
death_messages
default
digilines
digilines_converters
digilines_craftrecipes
DOM
doors
dye
explorertools
explorertoolsall
external_legacy
farming
farming_plus
fences
fire
flowers
food
forth_computer
framedglass
give_initial_stuff
gloopblocks
gt1111
homedecor
hud
hydro
intllib
item_drop
landrush
legacy
mccarpet
memorandum
mesecons
mesecons_wireless
mg
minetest_irc
mods.txt
moonflower
moreblocks
morefences
moreores
moretrees
mtfoods
names_per_ip
no_guests
pie
pipeworks
plantlife
replacer
scaffolding
screwdriver
sethome
stackablebucket
stained_glass
stairs
technic
tnt
trash_can
travelnet
unifiedbricks
unifieddyes
unified_inventory
u_skinsdb
vessels
whoison
windmill
windmill_large
wireless
wool
WorldEdit
xban2
xpanes

there are diamonds, mese, bronze sword in default as well as cement, evil in gloopblock
and silver, mithril sword from moreores, there might even be others, why not just do a simple string check like string.match(tool, "sword") instead?
that would cover every single possible sword.
https://github.com/PilzAdam/farming_plus/blob/master/pumpkin.lua#L68

not a real big issue just that the name an variable of s could be null and it gets not checked.
a litte few comments at all.

Unfortunately the mod doesn't follow conventions placing its data and functions not in a table corresponding to the module name (aka farming_plus), but in the table farming.

Leading to a clash with the built-in farming mod shipped with 4.016.

Well, to be percise there is even two clashes.
One with the field farming.registered_plants that gets happily reset to {} by the farming_plus mod.
Not a big deal as the built-in farming mod never makes use of it.

Worse is the clash with the function farming.place_seed() as this one is really needed by the built-in farming mod, but happily gets overwritten by the version shipped with farming_plus.
As an effect neither wheat nor cotton will grow if farming_plus is used.

IMHO data and functions of the mod should really, really live in the namespace (aka table) farming_plus to A) fix the current issue B) prevent future problems like this one.

To verify the named function really is the culprit I ran a quick 'sed -i s/place_seed/FIXME_place_seed/g' over the lua files of the mod.
Wheat is growing again after that operation.