Git Product home page Git Product logo

ember-strap's People

Contributors

pierrickrouxel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

qraft nruth takng

ember-strap's Issues

html in tooltip

Hi,

How can i enable html in the tooltip? I have tried adding to the component call

html=true

and also in the sender

data-html=true

but neither work.

thanks.

Title attribute for <a> element is replaced by es-popover

I have this:

 <a href id={{computedId}} {{action 'catchAction'}} title="My Title">Sort</a>

 {{#es-popover class="sortingPopup" placement="auto left" for=computedId as |popover| }}
   ...
   <button  id="{{computedId}}-sort-menu-close" 
                   class="btn btn-default"
                   type="button" 
                   {{action 'hide'    target=popover}}>Close</button>
 {{/es-popover}}

This results to render <a> as:

<a href="" id="sort-menu-ember1133" title="" data-ember-action="1134" data-original-title="My Title">Sort</a>

and the text in title attribute becomes the title of popover.

Is there anyway I could actually tell es-popover to leave the title attribute of the <a> element as is and not use it for popover title?

Better error message with modals

When there is no queryParams in the controller, an Ember error is generated.

EmberStrap should produce an understandable error message.

Popover Issues

When implementing popovers, I ran into a build error following EmberStrap. When I removed as |popover| everything worked fine. I'm also trying to apply a custom animation however I'm running into issues with my transform coming from the top left of the page. Could this be related to Emberstrap? See below for my current implementation.

EmberStrap Guide

<button class="btn btn-primary" id="popover-example">Show popover</button>
{{#es-popover for="popover-example" as |popover|}}
  Some content
  <button class="btn btn-default" type="button" {{action 'hide' target=popover}}>Close</button>
{{/es-popover}}

Current Implementation

<li>
  {{#link-to 'notifications' id='notifications-popover' role='button'}}
  <i class='icon icon-lightning'></i>
  {{/link-to}}
</li>

{{#es-popover for='notifications-popover' animation=true mode='click' placement='bottom'}} 
Testing this popover! 
{{/es-popover}}

CSS

.popover.bottom.fade {
    position: absolute;
    @include transform(translateX(-10px));
    @include ease(transform);
}

Thanks for your help!
Eric

Flickering effect when using popover

Hi!

I was doing some tests to see if this add-on was suitable for me and I realized that adding to the popover component a mode="hover" makes the popover behave in a continuous flickering.

edit: to be more specific, it happens when you move quickly the mouse over the button.

ember 2.8 crashes at startup: Uncaught Error: Could not find module ember-htmlbars/keywords/view

Uncaught Error: Could not find module ember-htmlbars/keywords/view

Some view related things were removed in 2.6 and 2.8.

https://github.com/emberjs/ember.js/blob/master/CHANGELOG.md
emberjs/ember.js#13757
emberjs/ember.js#13773
emberjs/ember.js#13315

https://github.com/pierrickrouxel/ember-strap/blob/master/addon/ember-internals.js says
// This gives us a non-deprecated view keyword
which sounds like it silenced the deprecation warning instead of fixing it?

Scrollspy - Not Affixing Consistently Due to Ember Routes

I'm having issues getting the ScrollSpy .affix method to stick consistently at the top of the page. I believe this is due to Ember and how the framework loads routes.

Basically, when I enter the Route where I have the scrollspy .affix method inserted from another route, the .affix method won't activate and stick to the top of the page. However, if I refresh the page (which loads the route fresh) then the .affix method works fine and users are able to view Scrollspy as they scroll down the page.

Any thoughts on how to get the .affix method to work consistently without loading the route fresh every time?

Here is my HTML

<div class='scrollspy-block'>
<div class='scrollspy' data-spy='affix' data-offset-top='400'>
<ul class='nav'>
<li class='help-section'>Getting Started</li>
<li class='help-subsection'><a href='#create-account'>Creating an Account</a></li>
<li class='help-subsection'><a href='#find-friends'>Finding Friends</a></li>
<li class='help-subsection'><a href='#details'>Your First Event</a></li>
</ul>
</div>
</div>

Here is a link to the live page: http://myhubapp.com/help/getting-started

how to implement

Hi Please excuse my inexperience, however could you expand on your usage instructions for me? for step 3 you have:

Call modal() within your router map, at whichever scope you choose and wire up any actions: 

what is a router map? I tried placing your example code in one of my module(pod)s route.js file and I get an error:

this.modal is not a function

which would imply to me that I need to extend something to get the route to understand it?

many thanks, and sorry for the (probably) dumb question.

Edit. So i did some experimenting I realise now you are referring to the core router.js file and the Router.map call in there. However I still get the this.modal is not a function error, which is what I would expect if we are not extending something else first? what am I missing :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.