Should we trash our cheapest item and take the new item or should the new item stay on the corpse ?

can we have the option to make our own keybind? it messes up other key-binds I have on shift and ctrl

Could also permit to have other key binds.

Every time when i (or party member) loot everything for 1st time the text appears. When we roll any item it duplicates 5-6 times. Don't wanna see this spam

When we have multiple stacks of exchangeable items, the one that we want to exchange isn't always the one that is highlighted. Often, it's the biggest one because Bagnon sort them from the biggest to the smallest and the first one is taken.

In order to be able to do #11 we need to add localization for all string first.

Make the items glow in the bags of Bagnon users.

Everything happens in the SetBagItemGlow function, where we need to add a conditional to recover the item for the specific bag addon.

With an addon I am working on, I was trying to debug a chat filter . After about 2 hours of not getting the output I was expecting, I disabled Grey Handling (as I noticed the name pop up a lot in chat when it shouldn't) and I finally got the output I was expecting.

This addon seems to cause lots of problems when trying to print to a chat frame using print. It seems to gobble up everything after the first argument to print. Just running /run print("test") outputs GreyHandling: test to the chat frame. GreyHandling should not be intercepting these calls.

I don't wanna use Scrap's junk list. Can you add option to ignore scrap list? I don't wanna throw away some stuff i marked in Scrap, i need this things for vendor.

https://www.curseforge.com/wow/addons/greyhandling#c49

Whenever I log into the game, I get an error between Bagnon and Greyhandling:

Date: 2019-12-23 12:32:22
ID: 1
Error occured in: Global
Count: 1
Message: ...nterface\AddOns\GreyHandling\Bagnon_GreyHandling.lua line 12:
   attempt to index local 'ItemSlot' (a nil value)
Debug:
   ...nterface\AddOns\GreyHandling\Bagnon_GreyHandling.lua:12: in main chunk
Locals:
A = "GreyHandling"
GreyHandling = <table> {
 member_leave_frame = <unnamed> {
 }
 NAME = "GreyHandling"
 IS_CLASSIC = true
 loot_frame = <unnamed> {
 }
 print = <function> defined @Interface\AddOns\GreyHandling\constants.lua:40
 bluePrint = "6699ff"
 DESCRIPTION = "Helps you get rid of the right grey objects when your bags are full"
 DEVELOPMENT_VERSION = false
 SELL_PRICE_TEXT = "Sell Price:"
 db = <table> {
 }
 isJunkByItemLink = <function> defined @Interface\AddOns\GreyHandling\functions\GetCheapeastJunk.lua:19
 data = <table> {
 }

Can you add compatibility with Peddler? Should be the same as Scrap.

So you can give something useful but cheap to a teammate without asking something in return. That's what I always do in-game, it's faster than asking for something, and most of the time its beneficial long term because of the goodwill it create.

Some users just don't want to use the auction house. Exclusion list not included.

Following a request in #9, we could localize the addon for Chinese users. I don't know any Chinese so the translation would be really bad unless I'm helped by someone knowledgeable.

It seems that the WOW API does not give the real vendor value with getItemInfo(). It even gives an item link with wrong value for gold. (64 copper for a 2s99c item).

It's a bug, but I think it's in the WOW API, so I don't know how to fix it right now.

Affect only common weapon/armor, so it only affects the very low level players, because later weapon and armor are grey or green but rarely white.

I don't think I'll take more time for this, but PR welcome :)

The most likely possibility is that the cheapest objects did not move. Instead of searching for it in the whole bag, just try to search it where we think it is first. Then, if it moved, search for it everywhere.

I am using the 0.5.2c version on the Chinese client. When my mage makes "Conjured Fresh Water" or "Conjured Bread", I get the following error:

2x ...Ons\GreyHandling\functions\handleChatMessageLoot.lua:5: table index is nil
...Ons\GreyHandling\functions\handleChatMessageLoot.lua:5: in function `updatePlayersList'
...Ons\GreyHandling\functions\handleChatMessageLoot.lua:24: in function `handleChatMessageLoot'
GreyHandling\GreyHandling-0.5.2c.lua:18: in function <GreyHandling\GreyHandling.lua:17>

Locals:
player_id = nil
player_name = ""
(*temporary) = <table> {
 PlayerID1AEBCFE1123123 = "TestName-TestServer"
}
(*temporary) = nil
(*temporary) = "table index is nil"
GreyHandling = <table> {
 NAME = "GreyHandling"
 IS_CLASSIC = true
 loot_frame = <unnamed> {
 }
 data = <table> {
 }
 OPTION_COMMAND = "/gho"
 DESCRIPTION = "Helps you get rid of the right grey objects when your bags are full"
 GetLocalization = <function> defined @GreyHandling\constants.lua:51
 SELL_PRICE_TEXT = "卖价:"
 options = <table> {
 }
 frame = <unnamed> {
 }
 DISPLAY_NAME = "Grey Handling"
 functions = <table> {
 }
}

This would permit to take resell value into account. Should also permit to add a modificator if you have to resell it (default to 30 coppers for sending it to your mule.)

Not sure if I just never noticed this or if it changed after the latest update, but when I was in a party and I pressed shift ctrl, greyrunning only gave me the suggestion to trade with another player. But it didn't pick up or point out my cheapest item.

Is there a way to turn off the party trade suggestions? I feel like most of the time I don't want to bother with trying to find do mutually beneficial trades.

Hey and thank you for your great addon!

Is your Classic addon compatible with just the default bags or with other "bag addons" currently compatible with WoW Classic, like Inventorian (which I will use), OneBag3 Classic or ArkInventory Classic?

I would love to use it but is it means using default bags, it's a no-go for me.

Can you specify the compatibility of your addon in the description? 😄

EDIT: adding the Classic tag.

Make the items glow in the bags of Inventorian users. Opened following #2 because OneBag3 and ArkInventory now works. Everything happens in the SetBagItemGlow function, where we need to add a conditional to recover the item for Inventorian.

The database is not updated when you exchange an object with someone, so if the other user do not have GreyHandling, the database is out of sync and useless.

EU English it saying that it has problem with my localization and that language is "Chinese?"

Following #9 there is API message when the player is looting for the first time. This is due to the fact that the API for chat loot message is different in classic than in retail. The player is looting the object so we do not have to track its object and we do not have to call getItemInfo. But we did not realize its the player because of those API changes.

Rings, trinket, cape and shirt do not have durability so the "100% durability" text should be hidden.

With the optimization made recently to calculate the cheapest object less often, it became apparent that scrap/peddler update to the junk list are not taken into account. Right now the solution is to launch manually to update.

BoP (Bind on pickup) items can't be exchanged, even if they're considered as junk by the player.

Right now calculations are done very often in particular for ArkInventory and Bagnon (for each update of a ButtonFrame). The addon should calculate once use a global value and then re-calculate only when needed. (In case of loot, exchange, sell, or throw ?)

Permit to test myself if #12 work before asking for someone help in a language I do not know.

The value the vendor give for a piece of equipment decrease with the damage done to it.

A torso worth 18 copper at 60/60 is worth 6 copper at 45/60.

Must confirm that it's still the case for wow classic and take it into account.

After the update that provides bagnon support, I notice that I no longer get the coin icon over the items that will be scrapped.

I have Bagnon, Scrap, bagnon_scrap, and greyhandling enabled. If I disable greyhandling I can see the coin icons again from scrap.

I see this was already fixed in a recent commit but please publish a new version asap as the current version is practically unusable with the chat spam (Calculated cheapest object).

Since there is still no Bagnon compatibility, it's difficult to find the two items in the bag when there is a "cheapest now" and a "cheapest later" since the item won't glow or highlight
It would be nice if there was a setting to just force pick "Cheapest now" so you don't have to find the item in your bag (but still show the two options in the chat window)?

Right now we have a permanent white glow used for action suggestion by Blizzard. Everything happens in the SetBagItemGlow function, where we need to better get the item for arkinventory.

We had some help from the arkinventory maintainer here :
arkayenro/arkinventory#1193 (comment)

Hi !

First thx for your add on, it's really nice to have. I would like to make a feature suggestion because it has happened to me quite often that the lowest priced item is actually not a grey but an other item like a consumable. Would it be possible to allow players to manually add items to the pool of items they want the add on to consider as trash ?

Anyway thx for your work :)

Xatrith

https://classic.wowhead.com/item=2678/mild-spices

Ie "Give me two fangs, I'll give you 5 broken eggs so we have one more bag space each", but industrialized.