picovico / python-sdk Goto Github PK

View Code? Open in Web Editor NEW

4.0 7.0 1.0 4.84 MB

The official python-sdk from Picovico ($ pip install picovico)

Home Page: https://api.picovico.com

Python 100.00%

picovico slideshow-maker video-maker-api python-sdk

python-sdk's People

Contributors

Stargazers

Watchers

Forkers

sagarchalise

python-sdk's Issues

expected api request class

request_post
request_get
api_request_put
api_request_delete


class Api:
        def get_api_headers(is_anonymous):
                if is_anonymous():
                        headers = anonymous_headers()
                else:
                        if not authorized
                                uNauth excetpion
                        headers = auth_headers()

                return headers

        def put(url, data, is_anonymous=False):
                response = requests.put(api_endpoint + url, data=data, headers=self.get_api_headers(is_anonymous))
                return get_sdk_response(response)

        def put(url, data, is_anonymous):
                response = requests.put(url, data=data, headers=self.get_api_headers(is_anonymous))
                return get_sdk_response(response)

        def put(url, data, is_anonymous):
                response = requests.put(url, data=data, headers=self.get_api_headers(is_anonymous))
                return get_sdk_response(response)

        def put(url, data, is_anonymous):
                response = requests.put(url, data=data, headers=self.get_api_headers(is_anonymous))
                return get_sdk_response(response)


        def get_sdk_response(response)        :
                - exception handling
                - json decode

Delete unnecessary file from feature branch

Delete unnecessary file from feature branch v2.0

pep8 validations

tests practices and standard

Please refer to some standard libraries like facebook sdk and similar and lets try to follow some of the test practices / exceptions handling those libraries have used.

Refactor API Request class

The staticmethods should be avoided wherever possible.

Different output format

Currently, the output format is just json maybe yaml and others could be nice.

coverage testing

pypi lib import should be refactored

from picovico import PicovicoProject

pypi package submission steps

https://packaging.python.org/en/latest/installing/#installing-requirements

(CLI) output meta information other than the actual response to stderr

python setup.py test yields error

Installed /tmp/easy_install-AfcQay/mock-2.0.0/pbr-1.9.1-py2.7.egg
Marker evaluation failed, see the following error.  For more information see: http://docs.openstack.org/developer/pbr/compatibility.html#evaluate-marker
ERROR:root:Error parsing
Traceback (most recent call last):
  File "/tmp/easy_install-AfcQay/mock-2.0.0/pbr-1.9.1-py2.7.egg/pbr/core.py", line 111, in pbr
    attrs = util.cfg_to_args(path, dist.script_args)
  File "/tmp/easy_install-AfcQay/mock-2.0.0/pbr-1.9.1-py2.7.egg/pbr/util.py", line 248, in cfg_to_args
    kwargs = setup_cfg_to_setup_kwargs(config, script_args)
  File "/tmp/easy_install-AfcQay/mock-2.0.0/pbr-1.9.1-py2.7.egg/pbr/util.py", line 431, in setup_cfg_to_setup_kwargs
    if pkg_resources.evaluate_marker('(%s)' % env_marker):
  File "//home/machine/.virtualenvs/picovico-python-sdk/local/lib/python2.7/site-packages/pkg_resources.py", line 1302, in evaluate_marker
    return cls.interpret(parser.expr(text).totuple(1)[1])
  File "//home/machine/.virtualenvs/picovico-python-sdk/local/lib/python2.7/site-packages/pkg_resources.py", line 1337, in interpret
    return op(nodelist)
  File "//home/machine/.virtualenvs/picovico-python-sdk/local/lib/python2.7/site-packages/pkg_resources.py", line 1250, in atom
    return cls.interpret(nodelist[2])
  File "//home/machine/.virtualenvs/picovico-python-sdk/local/lib/python2.7/site-packages/pkg_resources.py", line 1337, in interpret
    return op(nodelist)
  File "//home/machine/.virtualenvs/picovico-python-sdk/local/lib/python2.7/site-packages/pkg_resources.py", line 1271, in comparison
    raise SyntaxError(msg)
SyntaxError: '<' operator not allowed in environment markers
error: Setup script exited with error in setup command: Error parsing /tmp/easy_install-AfcQay/mock-2.0.0/setup.cfg: SyntaxError: '<' operator not allowed in environment markers

Profiles should not be case sensitive

PROFILES should not be case sensitive

Is caption missing in photo upload ? (CLi command)

pip install picovico -successful but picovico-client throwing error

$ which picovico-client
$HOME/.virtualenvs/picovico-python-sdk-test/bin/picovico-client

$ picovico-client
from: can't read /var/mail/picovico.cli.argsparser
$HOME/.virtualenvs/picovico-python-sdk-test/bin/picovico-client: line 5: syntax error: unexpected end of file

refactor test with unit test

Unit test for sdk methods
Mocked requests test for api methods

Categorize URL config based on API endpoints.

The URL endpoints should clearly define the workflow. They should be categorized.