pichfl / decknamen Goto Github PK

Polling might be a safer choice ¯_(ツ)_/¯

Somehow when I joined with Chrome it added two players instead of one. I could only control one, there was no way for anybody to remove the unusable player, but it remained in game for the whole time.

How about having an option to remove other players? At least for the leads or for the person who created the session

The icons are neat but make it much harder to test and deploy as well as impossible to make the repo public.

Consider converting icons to svg-jar or plain inline-svg

• Add a few more terms to complete the 400 count
• Remove "Araber"

Seems mobile browsers will not keep the websocket alive, which is a bummer.

Testing

• Browser notifications
• Polling when user interaction is detected (probably on touchstart)

I tried to work with two different rooms to separate players and game state, but it doesn't make sense to keep them separate. The moment the cards are added, the player state may no longer be modified and it's much easier to check that sync in a single state object.

Also, it makes sense to have a single representation based on an concurrency task, with the substates being represented by readOnly getters.

Automatic removal of players seems to be more confusing and problematic than anticipated.

• Add button to manually remove players
• Change API to not drop players when they leave the room at any time

Developing the API locally requires Redis now. You can use the Heroku or any other Redis instance at will, but you need to know how.

Textfield with the current game URL/token and a button to copy it to the clipboard for sharing.

https://www.kirilv.com/canvas-confetti/

I think it has something to do with my naive state merging/creating approach

If a game is in progress, nobody else can join. Show an error screen instead of redirecting them to the index page.

• https://www.horsepaste.com/look
• https://en.wikipedia.org/wiki/Codenames_(board_game)

Major screens

• Lobby - assign players to teams and define roles (spy masters)
• Game - the fun part

(No more wikis on free Github 😞)

Right now you end up in the game over screen in an unknown state. That's not good.

..., Dealer, Dèjá-,Vu, Delta, ...

After restating a game with the same players, my Safari and Firefox controlled the same player in game.

Using the first two letters of the locale should be fine for most cases for now.

We have multiple word lists, it should be possible to select the "edition" before starting the game.

I suggest we add a simple <select> to the lobby screen that any player can change until the "start game" button is pressed, which should obviously lock in the selection

There seems to be an error with the player name sometimes ending up empty. to change that, we should check and copy over the local player name on reconnect.

Leaving the browser tab on a phone scrambles the connection.

There should be an event that can be used to trigger a sync when the window becomes active again.

Right now it is possible to read the game state in plain text which makes it easy to cheat by simply looking at the socket communication which sends around the game state (boooh to those who try that). Running a simple cypher could help to stop that. of course it can still be decoded, but it involves an extra step. ¯\_(ツ)_/¯

Any opinions?

• wins
• losses
• deaths

update
Should be much easier now that we have the lobby inside Redis

• Show number of running games
• Remove sessions after 1 week of inactivitity

Seems one of the locks doesn't quite resolve