Git Product home page Git Product logo

Comments (7)

Phylliade avatar Phylliade commented on May 26, 2024

Good catch @cjlux !

Actually this function seems deprecated and should be removed (seems it's not used anywhere).

In which context did you use it?

from ikpy.

cjlux avatar cjlux commented on May 26, 2024

We (Yoan Mollard, Thibault Desprez and myself) are presently updating the raspoppyfication process (installing Poppy configuration on a RPi4 under raspbian buster) : the IKpy module is used at start-up by the robot "Ergo Junior" and I found also this bug when using IKpy for the robot "Poppy Torso" to make the robot catch objects recognized by tits camera.

from ikpy.

cjlux avatar cjlux commented on May 26, 2024

sorry closing was accidental...

from ikpy.

Phylliade avatar Phylliade commented on May 26, 2024

In order to use URDF, the function get_urdf_parameters should be used instead.

from ikpy.

Phylliade avatar Phylliade commented on May 26, 2024

On the other hand, if you explicitly need it, we can move it to a "deprecated" module (and fix the original issue), instead of just removing it.

from ikpy.

cjlux avatar cjlux commented on May 26, 2024

After investigation I found this : the function get_chain_from_joints defined in the file URDF_utils.py is called at line 25 of the file ik.py from the module pypot.creature :
25 chain_elements = get_chain_from_joints(poppy.urdf_file, [m.name for m in motors])
and the liste chain_elements contains for example :
['base', 'abs_z', 'spine', 'bust_y', 'bust_motors', 'bust_x', 'chest', 'l_shoulder_y', 'l_shoulder', 'l_shoulder_x', 'l_shoulder_motor', 'l_arm_z', 'l_upper_arm', 'l_elbow_y']

Some lines later in the file ik.py the list chain_elements is given as argument to the call :

30         chain = cls.from_urdf_file(poppy.urdf_file,
31                                    base_elements=chain_elements,
32                                    last_link_vector=tip,
33                                    active_links_mask=activ)`

and the function from_urdf_file (in the file chain.py from the module IKpy) calls itself the function get_urdf_parameters with among others the argument base_elements=chain_elements...

So if you plan to deprecate the function get_chain_from_joints the question is : how to generate the list chain_elements ?
Or a related question is : what kind of information in details is required for the argument base_elements of the get_urdf_parameters function ?

from ikpy.

Phylliade avatar Phylliade commented on May 26, 2024

Actually this function seems useful in the way it's used, since it permits to get a list of links+joints from a list of joints.

And this use-case can be appear in the pypot creatures context: Since IKp's URDF parser requires a list of links+joints, and pypot works with a list of joints, this function makes the link between the two

from ikpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.