phpbb-extensions / phpbb-ext-skeleton Goto Github PK

when clicking on the link I get a Symfony error.

• phpbb 3.3 installed with Quickinstall.
• php v7.3.20

Fatal error: Uncaught Error: Call to undefined method Symfony\Component\Yaml\Parser::parseFile() in /Users/Nix/Sites/qi/boards/v3301/vendor/symfony/routing/Loader/YamlFileLoader.php on line 67

I get an informational error that says, "The selected extension cannot be enabled, please verify the extension’s requirements."

The "roadmap" for adding more elements to the skeleton extension for completeness:

• Cron
• Console command
• Notification
• UCP/MCP modules
• ACP template event listener
• ext.php
• Build script

https://github.com/phpbb-extensions/phpbb-ext-skeleton/blame/3.1.x/composer.json#L15-L24

Considering the fact that at least one PR is devoted to make this 3.2 compatible the composer.json should take into consideration that for 3.2 the minimup PHP required is 5.4.

Also for completeness the <3.2.0@dev bit should be removed.

About the EPV an issue has been already created.

Because of the power of twig, we're already using it a tiny bit in the skeleton "tpl" files. They should all be converted over completely, and move away from old silly phpBB template syntax. And then the work-arounds implemented to handle the weaknesses of the old syntax can also be removed.

This results in invalid version requirements, for example:

    "require": {
        "php": ">=5.3.3"
    },

        "soft-require": {
            "phpbb/phpbb": ">=3.1.4,<3.2.0@dev"
        }

It could be nice if the UCP part will be taken in consideration too

in skeleton/helper/packager the use of 'Symfony\Component\Finder\Finder' is declared and thus into the function 'create_zip($data)' it is called. But in phpBB 3.1.x that Symphony Folder does not exists hence this error:

Class 'Symfony\Component\Finder\Finder' not found in \ext\phpbb\skeleton\helper\packager.php on line 167 ...

---> line: $finder = new Finder();

phpbb/finder.php should be used? Maybe a switch to be created for the 2 phpBB series?

$phpbb_extension_manager?

Using the present repo with phpBb 3.1.12 (no probs with 3.2.2)

When generating a controller, this line is added in the handle() method:

return $this->helper->render('myext_body.html', $name);

I think @vendor_extname should be included:

return $this->helper->render('@vendor_extname/myext_body.html', $name);

Say you created an extension named "myawesomeextension" with some components but you aren't satisfied of the resulting package due to some cause, it doesn't really matter.. now you want to recreate it with the same name.

Here's a screenshot of the error (deleting from the store folder the old extension will do but..)

Some comments on usability after generating an extension with the latest changes:

• All CP migration files are being generated even if they aren't all selected:
  
  
• ACP language files are being generated with the package name for the key values instead of the display name.
• depends_on for migrations assumes 3.1 (v31x\v314) even though minimum is automatically being set to 3.2.0 on the interface.

On that last one there seems to be some sort of desire to keep 3.1 support in this extension even though 3.1 has been EoL since January 2018. All 3.1 support in this extension should be retired in the next release.

If you input
3Dç
will be rendered as
3D??
Example:

• @copyright (c) 2016, 3D??

Release has an empty phpbb file, or whatever, with a size of 0 when extracted?

Failed to obtain latest version information.

The requested file could not be found: skeleton_versions.json

I didn't select the notification component but I got this lang var into info_ucp_demo.php

'NOTIFICATION_TYPE_DEMO' => 'Use Acme demo notifications',

I think we should also create controllers for the CP Modules?
Cause I see more and more extensions with the same "issues".
Those being that $page_title and $tpl_name are not declared before usage.
That $user->lang[''] is still being used over $this->lang->lang('').
And that var should be replaced with public.

Anyways, I think a lot of good will come if we create controllers for the control panels modules.
I could have a go at it if you want.

$forum_row['FORUM_NAME'] .= ' :: Acme Event ::';
I think it should be better to get the language file also if you choose to have just the event listener instead to have an hard-coded string in there.

The extension:create CLI command does not register when this extension is installed and enabled. The extension shows enabled in both the ACP and extension:show in the CLI, but no extension:create. This is on phpbb 3.3.4, php 7.4.23. If I take the sample skeleton and move it into the phpbb/console/command hierarchy and hack stuff up, I can get it to work, so the sample.php is fine, it's just the services.yml is not being read or something?

I don't see any errors in the logs, even with DEBUG and DEBUG_EXTRA on.

I actually can't find a single example of a working extension with a CLI component for modern phpbb...I guess I'll hack my stuff into the main tree for now?

Thanks,
Chris

Once the User control panel (UCP) and Moderator control panel (MCP) are un-checked the logic still creates those migration files.

To add, there is not a check-box for create schema, but the logic does create that migration file too.

Database migration should be better defined I guess.
Thx.

Am I wrong or the link to "Create skeleton extension" in the navbar remains always visible, also to guests?

I think very strange that a guest that visit my site, can create his own extensions....

Thanks, Marco

Here's what's created there into those 2 files

demo_table

but the schema migration file say

$this->table_prefix . 'acme_demo'

Installed on a 3.2 test forum and got this error.

The components should probably be disabled by default, so by default a bare minimum extension is made. The user should add the components they want. Currently we have the opposite where all are enabled by default, and you have to remove the components you don't want.

In the web UI this means all the component check boxes should be un-checked by default.

In the Cli it means "No" should be the default when confirming which components to add.

it generates the notification names with dev.dev instead of vendor.name that is filled in.

Add core.viewonline_overwrite_location event listener to make an example of adding custom pages (front controllers etc.) to the viewonline.

The generated install_user_schema migration file could be enhanced a bit to include things like adding a config entry, config_text entry, permissions, a custom function, etc. that can serve as a basis (copy/paste-able) for whatever other migrations the extension author wants to create.

Feel free to include other useful migration features.

within packager which is building the composer.json file

'require-dev' => array( 'phpbb/epv' => 'dev-master',

don't believe this is a very good idea as extraneous, and possibly not wanted, directories will be included into an authors extension when compiled using composer update.

@prototech mind helping to fix this?

I just tried this from the phpBB controller page interface, and I only selected php listeners and service components, left all the others unchecked, but it still built an extension with every possible component.