casbin/casbin#661

The file is src/Adapter.php，on Line 117, Thanks!

I get this error when trying to instantiate the Enforcer class using this adapter:

TypeError:
Argument 1 passed to CasbinAdapter\DBAL\Adapter::fetch() must be an instance of Doctrine\DBAL\Result, instance of Doctrine\DBAL\Driver\PDOStatement given, called in /<redacted>/vendor/casbin/dbal-adapter/src/Adapter.php on line 153

  at /<redacted>/vendor/casbin/dbal-adapter/src/Adapter.php:495
  at CasbinAdapter\DBAL\Adapter->fetch(object(PDOStatement))
     (/<redacted>/vendor/casbin/dbal-adapter/src/Adapter.php:153)
  at CasbinAdapter\DBAL\Adapter->loadPolicy(object(Model))
     (/<redacted>/vendor/casbin/casbin/src/CoreEnforcer.php:363)
  at Casbin\CoreEnforcer->loadPolicy()
     (/<redacted>/vendor/casbin/casbin/src/CoreEnforcer.php:223)
  at Casbin\CoreEnforcer->initWithModelAndAdapter(object(Model), object(Adapter))
     (/<redacted>/vendor/casbin/casbin/src/CoreEnforcer.php:198)
  at Casbin\CoreEnforcer->initWithAdapter('/<redacted>/permission_model.conf', object(Adapter))
     (/<redacted>/vendor/casbin/casbin/src/CoreEnforcer.php:150)
  at Casbin\CoreEnforcer->__construct('/<redacted>/resources/permission_model.conf', object(Adapter))
     (/<redacted>/src/Utilities/Permission.php:52)

From the composer.json file in this library, Doctrine 2.9 and 3.0 are supported. I am using Doctrine 2.9.3.

Digging through the source code, it looks like the execute method from DBAL Query Builder (called on line 151 in Adapter.php) returns a ResultStatement rather than the expected Result object.

Passing an array of parameters instead of a Connection object in the constructor produces the same result. Am I doing something wrong?

Calls to removed methods

#7 claimed to add support for Doctrine 4.0, but there are still multiple calls to removed QueryBuilder::execute() method (along with some calls to other removed methods) across the codebase.

Broken automated checks

Cloning the repository and running the test suite results in 11/11 errors which means that the automated checks for the PR incorrectly passed. I took a glance at the workflow file and I suspect this might be due to Composer package caching, which skipped the Install dependencies step and probably used an old version of Doctrine.

Proposed solution

Fixing the source code itself isn't complicated and I might take a shot at it if I have time at some point attempted a fix (see #13), but I think fixing the tests should be the first priority, since that would've immediately detected the broken code. I also find it a bit odd that apparently no tests were run locally at any point.

There is a new version of dbal available and package need to be updated.

https://www.doctrine-project.org/2024/02/03/doctrine-orm-3-and-dbal-4-released.html