Comments (4)
npalm
commented on June 19, 2024
Please can you provide some more details? The issue is not clear to me? Is the problem the string is hard coded?
from terraform-aws-github-runner.
Lraharison
commented on June 19, 2024
Okay, when the value of the ssm_parameterNames parameter in the terraform ami-housekeeper module does not contain ami-id, the lambda ami housekeeper simply ignores it, so if the ami is older than the minimumDaysOld, it will be deleted. I hope I was clearer.
I'm not sure if the lambda code takes into account the value of this parameter or if it will just filter the SSM parameters containing ami-id in the name.
from terraform-aws-github-runner.
npalm
commented on June 19, 2024
Thx for the feedback, In case you have some time feel free to suggest a change in a PR.
from terraform-aws-github-runner.
github-actions
commented on June 19, 2024
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.
from terraform-aws-github-runner.
Related Issues (20)
- Runner i-xxxx is not idle in GitHub and NOT counted as part of the pool HOT 3
- SSM parameters can exceed 4K limit breaking terraform apply HOT 4
- Add support for multiple type of platforms HOT 1
- Docker containers no longer inherit credentials from EC2 instance HOT 1
- Add the ability to use custom labels only HOT 2
- AMI Parameter cannot be a cross account parameter HOT 1
- speedup instance creation for bursty workflows HOT 2
- CodeStar Connections Being replaced by CodeConnections in April 2025 HOT 1
- optional FIFO queue on workflow job events queue HOT 1
- Ephemeral runners start but never connect to github because of dnf failures HOT 3
- Clear working directory between runs? HOT 2
- Release 5.10.2 not starting any servers HOT 10
- Idle Config starting another worker HOT 1
- Unable to set SQS queue policy on experimental workflow_job_events_queue
- Scale Up Lambdas not working in 5.10.2 after upgrading from 5.9.0. HOT 2
- logging examples contains service undefined HOT 1
- SQS_WORKFLOW_JOB_QUEUE env variable not set for webhook Lambda HOT 3
- ebs_optimized variable is not propagated to submodules
- ScaleDown lambda fails to run if a "bad" runner exists
- Runners can't read SSM token on 5.11 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-github-runner.