Git Product home page Git Product logo

Comments (4)

claytonolley avatar claytonolley commented on August 17, 2024 2

My sincere apologies, I had not updated the lambdas. I'm pretty new to using this module so I will definitely note this for the future. Many thanks for sharing this solution!

from terraform-aws-github-runner.

npalm avatar npalm commented on August 17, 2024

Thx for reporting. I have tested 5.11 with the following scenarios

  • default example
  • multi runner
  • default example + pool
  • our own staging environment

The all work fine and the runners are getting the registration token?

from terraform-aws-github-runner.

npalm avatar npalm commented on August 17, 2024

Please can you double check you also updated the lambda functions. The control plane one contains a change. Without this change the new policy is not working since the tag is not set.

Here some steps to debug

  • update to 5.11
  • trigger a new job
  • check the token in SSM contains the tag of the instance, if not you most likely on an older version of the lambda

In case you still have the issue, please can you share more details about your configuration.

from terraform-aws-github-runner.

tetienne-zenchef avatar tetienne-zenchef commented on August 17, 2024

@npalm I was tricked also by this, despite the fact I read the changelog. What do you think about adding a warning into the release not when there is such strong dependency for a new feature?

from terraform-aws-github-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.