philippmdoerner / lowdb Goto Github PK

In sqlite, generally when you fire off a query and you have more parameters than corresponding placeholders in the query, you will receive a DBError.
See tests in the suite tsqlite.nim - suite "Prepared statement finalization": for examples.

insertId, rows etc. in postgres does not emit that behaviour. Fix that

Minimal example:

import lowdb/sqlite
import std/unittest

let dbConn = open(":memory:", "", "", "")
dbConn.exec sql"CREATE TABLE t1 (id SERIAL PRIMARY KEY, value TEXT)"

let id = dbConn.insertID sql"INSERT INTO t1(value) VALUES ('a')"
let rows: seq[Row] = dbConn.getAllRows(sql "SELECT * FROM t1")

assert rows.len == 1

let expectedValue: seq[Row] = @[
  @[
    DbValue(kind: dvkInt, i: id),
    DbValue(kind: dvkString, s: "a")
  ]
]
check rows == expectedValue

expectation: This should succeed.
insertID should insert an entry into the table AND add an auto-generated ID.

Currently it does not do that, it only adds the entry, it doesn't set the generated id.

SideInformation:

What's mysterious about this is, that it appears to generally work for norm, which is using lowdb and makes extensive use of it.
It also occurs in both nim 1.6.10 and 1.9.1, so it's not a bug caused by devel.

tryInsertID is implemented, but not for postgres, leading to various tests for postgres in tPostgres.nim being commented out.

The specification for that proc can be seen in tsqlite.nim - suite "Prepared statement finalization":.

getValue is implemented, but not for postgres, leading to various tests for postgres in tPostgres.nim being commented out.

The specification for that proc can be seen in tsqlite.nim - suite "getValue()":

• Update Readme
• Update file names
• Set up pipelines for docs and tests
• Update badges in Readme
• Publish to nimble packages

{.deadCodeElim: on.} is a deprecated noop and should be removed. Likewise, search {.deadCodeElim: on.} and replace them with empty strings.

DbBlob is implemented, but not for postgres, leading to various tests for postgres in tPostgres.nim being commented out.

The specification for that type is the same as sqlite, check out sqlite.nim and tsqlite.nim for basics of the specification.

instantRows is implemented, but not for postgres, leading to various tests for postgres in tPostgres.nim being commented out.

The specification for that iterator can be seen in tsqlite.nim - suite "suite "instantrows-iterator":