philbarker / ap2shacl Goto Github PK

SHACL Spec says

Note that multiple values for sh:class are interpreted as a conjunction, i.e. the values need to be SHACL instances of all of them.

But we want the value to be any one of the listed values, i.e. to expand multiple values into options sh:in () as with other properties.

E.g. in join up DCAT AP, valueDataType for dct:modified is "xsd:date xsd:dateTime"
This needs to be in SHACL as sh:or ([sh:datatype xsd:data] [sh:datatype xsd:dateTime])

Notes, in the join-up SHACL file this is in a node shape (DateOrDateTimeDataType_Shape), using sh:shape property on sh:property.

Without the explicit shape:

<catalogrecordshapeUpdate/modificationdate> a sh:PropertyShape ; 
    sh:or ([sh:datatype xsd:date] [sh:datatype xsd:dateTime]) ; 

works

If shapes csv has True for Madatory element, generate code to check whether any data matches shape.

When a shape is closed it would be useful to suppor sh:ignoredProperties: a list of properties that ignored: i.e. allowed in the shape but have no associated TAP propertyContraint / sh:PropertyShape.

Heading in shapes csv would ignoreProps, which would then be a key in the python AP shapes dict.

AP shapeInfo targetType key now has list values.

to support philbarker/TAP2SHACL#6
see also philbarker/APClasses#8

For numeric datatypes, can have value constraint type of maximum & minimum which correspond to sh:maxInclusive sh:minInclusive

equivalent to sh:class on a property shape: specifies that the value of a property must be typed to specific class[es].

Initially just single value.

e.g.
valueConstraintType = "objectClass"
valueConstraint = "sdo:Person"

<>  a sh:PropertyShape ;
    sh:class ex:Company . 

Don't leave people hunting for error in 100s of lines of csv e.g.:

• Print property statement before raising Exception: Incompatible node kind and constraint (ap2shaclConverter.py", line 336, in convert_valConstraints)
• add else: clause for value error for when target type not recognised & print shape info
• line 95, processing node types, error message tries to print non-existent variable
• others?