phanngor / screen-shooter Goto Github PK

I get this exception after pressing "Take Screenshots":

NullReferenceException: Object reference not set to an instance of an object
Borodar.ScreenShooter.Utils.GameViewUtil.AddCustomSize (Borodar.ScreenShooter.Utils.GameViewUtil+GameViewSizeType viewSizeType, UnityEditor.GameViewSizeGroupType sizeGroupType, System.Int32 width, System.Int32 height, System.String text) (at Assets/Plugins/Screen Shooter/Screen-Shooter/ScreenShooter/Editor/Scripts/Util/GameViewUtil.cs:66)
Borodar.ScreenShooter.ScreenShooterWindow+<TakeScreenshots>c__Iterator0.MoveNext () (at Assets/Plugins/Screen Shooter/Screen-Shooter/ScreenShooter/Editor/Scripts/ScreenShooterWindow.cs:224)
Borodar.ScreenShooter.Utils.EditorCoroutine.Update () (at Assets/Plugins/Screen Shooter/Screen-Shooter/ScreenShooter/Editor/Scripts/Util/EditorCoroutine.cs:61)
UnityEditor.EditorApplication.Internal_CallUpdateFunctions () (at C:/buildslave/unity/build/Editor/Mono/EditorApplication.cs:127)

After some digging through, I discovered that the ctor variable at the line 65 of GameViewUtil.cs is not fetching the constructor, but remains null, therefore the line beneath it fails because of null reference.

Simply getting all constructors and invoking the 0th one works since there are no other constructors in the target file. But this feels very hacky, since they can change this implementation in the future. Nevertheless, I will send you a pull request about this, the decision is yours.

I am using Unity 2017.3.1f1

Does this plug-in support runtime screenshots of code？
Thank U！

Hey, very awesome plugins when creatings metas for mobile games. 👍
Could it be possible to make the planeDistance value of canvas tweakable in some settings ?

Canvas[] canvases = GameObject.FindObjectsOfType<Canvas>();
Camera camera = Camera.main;
foreach(Canvas iCanvas in canvases)
{
         iCanvas.renderMode = RenderMode.ScreenSpaceCamera;
         iCanvas.worldCamera = camera;
         iCanvas.planeDistance = 👉 1f 👈 ;
}

As sometimes 1 unit is too close to some 3D element, and the UI end up cliping in it.

Thanks !

I will just leave it here so I don't forget.

Would be great to have "Autoincrement Tag" checkbox, so if the last symbol is number it will autoincrement it when you make a screenshot so you could iterate faster.

Hello.
The description claims the script captures screenshots, but this script renders camera.
In Unity, after image is captured from camera, there are screen overlays and post-processing effects not accessible through a Camera.
Is there an easy way to add those?