personinblack / black Goto Github PK

what is this feature you want to see on black
a handler to trigger the inventory close event

describe the bug
if you modify a slot when that slot is being clicked but do not cancel the event, you are doomed.

here is an example element:

new BasicElement(
    new ItemStack(Material.DIAMOND),
    new ClickTarget((event) -> {
        pane.add(
            new BasicElement(
                new ItemStack(Material.DIAMOND)
            )
        );
    }, new ClickTypeReq(ClickType.RIGHT)),
    new ClickTarget((event) -> {
        event.player().sendMessage("left click");
    }, new ClickTypeReq(ClickType.LEFT))
)

you can fix this element by adding a new target like this:

new ClickTarget((event) -> {
    event.cancel();
})

this target will cancel all the events it receives and the bug will be fixed. but of course you shouldn't have to do that...

expected behavior
stuff should happen normally and there shouldn't be any ghost items in the inventory.

even if you cancel the ElementBasicEvent, player can still shift click on their own inventory and transfer the item to a slot with cancelled event and air.

should be handled at Blackness#processPluginDisable by checking every players' open inventories and closing them if they are black.