perezhz / neos.jl Goto Github PK

Ref: Carpino et al., 2003

Related to discussion around this comment

We should aim for a full migration to JLD2, but that requires, among other things, re-generating most artifacts used by NEOs.jl using JLD2 instead of JLD

We already have docstrings thanks to the work done by @LuEdRaMo, and I think we can build on it to get a first version of the NEOs documentation, e.g. via Documenter.

While trying to register NEOs.jl in the Julia General registry (see relevant NEOs.jl commit, corresponding PR JuliaRegistries/General/pull/71434 and job log) auto-merge didn't work due to several issues:

• Name of package is not at least 5 characters long
• The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: DataFrames, HORIZONS, IntervalArithmetic, PlanetaryEphemeris, Query, ReferenceFrameRotations, StaticArrays, StatsBase
• I was not able to install the package (i.e. Pkg.add("NEOs") failed). See the CI logs for details.
• I was not able to load the package (i.e. import NEOs failed). See the CI logs for details.
• Package name similar to 2 existing packages.
  • Similar to NES. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.
  • Similar to NExOS. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

I'm opening this issue to try to resolve those issues, so that we can finally register NEOs.jl.

Besides discussing the name of the package (I would be in favor of keeping NEOs, but maybe NearEarthAsteroids could be an alternative), I think the other important points would be to fix the compat entries and using consistent bounds on TaylorSeries.jl and TaylorIntegration.jl throughout so that Pkg.add and Pkg.import work.

cc: @lbenet @LuEdRaMo

Currently, here:

This issue follows from an offline discussion with @lbenet and @LuEdRaMo. Currently, before performing a propagation, we use loadeph to precompute the accelerations and the Newtonian potentials of the perturbers (planets, asteroid, etc.) of a NEO orbit, besides changing the units of the ephemeris themselves from km and km/sec to au, au/day. But now we have NEOs.sseph, which would allow us to precompute these things, so that their computation can be taken out from the integration loop. This can help simplify code (and maybe improve performance?).

Not terribly urgent, but fixing this issue would allow us to avoid re-run tests which would otherwise pass

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!