pedrohnv / transient-analysis-grounding-systems Goto Github PK

See:

B. P. Silva, S. Visacro and F. H. Silveira, "HEM-TD: New Time-Domain Electromagnetic Model for Calculating the Lightning Response of Electric Systems and Their Components," in IEEE Transactions on Power Delivery, vol. 37, no. 6, pp. 4848-4857, Dec. 2022, doi: 10.1109/TPWRD.2022.3161082.

I should implement it one day

When downloading one of the releases, there is a cubature folder, but no files in it. The user must then manually donwload (or git clone). I should probably add its contents to the release to facilitate to the end user, but it is BIG (14 MB)...

The function nodes_from_elecs that extracts a list of unique nodes from a list of electrodes does not work as intended.

There is a loop in the function laplace_trans that assigns a complex value to a real array. That is a silent bug waiting to happen. Though, none of the examples calls this function or its inverse, they commit the exact same error.

double* in = fftw_malloc(nt * sizeof(double));  // real array
...
in[k] = f[k] * dt * cexp(-c * k * dt);  // complex value

Algorithm as published in [1]. I probably messed the array indexing.

[1] VIEIRA, Pedro H. N. et al. Symmetry exploitation to reduce impedance evaluations in grounding grids. International Journal of Electrical Power & Energy Systems, v. 123, p. 106268, 2020.