pbakondy / mcc-mnc-list Goto Github PK

Hello,

I found a wrong mcc in https://raw.githubusercontent.com/PodgroupConnectivity/mcc-mnc-list/master/mcc-mnc-list.json

Wrong value

"mcc": "United Kingdom - GB - 235\n235",
"mnc": "00",

"mcc": "Japan - JP - 441\n441",
"mnc": "00",

Correct value

mcc : 235
mnc : 00

mcc : 441
mnc : 00

possible cause

• view-source:https://en.wikipedia.org/wiki/Mobile_Network_Codes_in_ITU_region_2xx_(Europe) includes an unexpected value after

<tr>
<td><div style="overflow:hidden;width:0;height:0;margin:-1ex;float:right">
<h3><span class="mw-headline" id="United_Kingdom_-_GB_-_235">United Kingdom - GB - 235</span></h3>
</div>235
</td>

• view-source:https://en.wikipedia.org/wiki/Mobile_Network_Codes_in_ITU_region_4xx_(Asia)

<tr>
<td><div style="overflow:hidden;width:0;height:0;margin:-1ex;float:right">
<h3><span class="mw-headline" id="Japan_-_JP_-_441">Japan - JP - 441</span></h3>
</div>441
</td>

Based on the statement

"List of MCC and MNC codes from up-to-date Wikipedia page Source: https://en.wikipedia.org/wiki/Mobile_country_code

This indicates that the file mcc-mnc-list.json should be licensed under the terms of the Creative Commons Attribution-ShareAlike License. "under the same, similar or a compatible license"

From the Wikipedia page "Text is available under the Creative Commons Attribution-ShareAlike License;"

The other files in the repository can be under the MIT license. But, the data file itself must be released under a license compatible with the CCA-SA license. As far as I know the MIT license is not compatible with the CCA-SA license since the CCA-SA requires attribution but the MIT license does not.

I suggests that you update the LICENSE file to be 1) CCA-SA or if you really want to keep the other files as MIT then a dual LICENSE where the .js and other files are MIT and the data file is CCA-SA.

Hi,
i got the error when installed this module.

Module parse failed: Unexpected character '#' (1:0)
You may need an appropriate loader to handle this file type.
| #!/usr/bin/env node
|
| 'use strict';

could you please help

Hello.
Your code is very helpful.
Thank you for developing and maintaining.

When I've downloaded your source and run the following command, mcc-mnc-list.json is updated.

node fetch.js

But countryName and countryCode are null.
The reason seems like the WIKI page has en dash (–) but your code checks hyphen(-).
https://github.com/PodgroupConnectivity/mcc-mnc-list/blob/master/fetch.js#L55 returns en dash (–)

Is this expected? Or did I've done something wrong?

Thank you in advance.

Regards,
Jun

It is my understanding that an MNC and MCC combination should be considered unique. Upon inspecting the data, I have found 41 instances where an MCC and MNC pair share more than one entry. Attached is a CSV that denotes the identified MCC and MNC and how many times the pair occurs within the JSON file.

duplicate_mcc_mnc.csv

I've been looking for something like this, but with access point names for the different networks where it applies.
I almost installed it before noticing that there are no APN.

What are people using a package like this for, without the APN?
I need to present the user with a nice list of carriers and then use the selection to set the APN.

Thank you for creating and maintaining this - it's incredibly useful 👍

mcc-mnc-list.json is fairly large and verbose but can be used independently. Is it possible to also store it in CSV format for external consumption ? Similar to https://github.com/musalbas/mcc-mnc-table/blob/master/mcc-mnc-table.csv

If I knew js well, I'd have sent a PR to do this. I understand that json to csv conversion can be made on the client end and this request can possibly be beyond the scope of this project. If that's the case, feel free to close this issue. Cheers!

Ranges are not expanded into separate records and therefore the MNCs cannot be found. For example, a filter of { mcc: 313, mnc: 111 } will not return the following record:

  {
    "type": "National",
    "countryName": "United States of America",
    "countryCode": "US",
    "mcc": "313",
    "mnc": "110 - 190",
    "brand": "FirstNet",
    "operator": "700 MHz Public Safety Broadband",
    "status": "Unknown",
    "bands": "LTE",
    "notes": "D Block for future use"
  },

Perhaps this is a better source of carrier mcc mnc information:
http://mcc-mnc.com/

The country name and country codes for T-Mobile US: MCCMNC: 310260 are listed as Puerto Rico. I believe they should be listed as United States-US.