It seems to be because trap - DEBUG is run inside of a function (_shellhistory_disable).

A quick fix for this is to use PROMPT_COMMAND to unset it instead:

new_prompt_command=${PROMPT_COMMAND//_shellhistory_after;}
PROMPT_COMMAND="trap '${trap:--}' DEBUG; PROMPT_COMMAND='${new_prompt_command}'"

Explanation:

• first we compute the new prompt command (the one without shellhistory)
• then we set PROMPT_COMMAND to:
  • a command that will update the trap (when $trap is not empty) or remove it (when $trap is empty, will be replaced by -)
  • and a command that will set it to the new prompt command

my system

$ uname -a
Linux novo 4.15.0-39-generic #42-Ubuntu SMP Tue Oct 23 15:48:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ zsh --version
zsh 5.4.2 (x86_64-ubuntu-linux-gnu)

my problem

when I open a shell (e.g gnome-terminal) 3 errors appear:

_shellhistory_last_command:fc:2: event not found: -0                            
_shellhistory_last_command_number:fc:1: event not found: -0
_shellhistory_last_command:fc:2: event not found: -0

I can keep using my shell, but no command data is logged.

solution

• change arg of fc command in line 15 of shellhistory.sh to ... -lnr -1 ...
• change arg of fc command in line 19 of shellhistory.sh to ... -lnr -1 ...

my solution

this PR

the question

why does fc not work with arg -0 ? Is there a problem with my shell setup?

@pawamoy thanks for your work

I use a span in the bootstrap alert to set the text from jquery, but when the text is long or multiline, the display is broken.

The value of this parameter is expanded (see PROMPTING below) and displayed by interactive shells after reading a command and before the command is executed.

Cons: must run commands in a subshell, therefore unable to set variables. Must write in a file and then retrieve contents after execution.

Pros: not subject to debug printing.

Commands starting with spaces won't be added to the current bash history (depending on configuration), therefore _last_command will return the previous added command, not the current one.

When we enter an empty command, the last one (from builtin history 1) is appended to the extended history file. I have only one idea to fix this: record the BASH_COMMAND variable and check if it's empty (or composed of spaces). An issue with that is that the comments will be removed I think, so typing #just a comment would not be appended to history (is it really a problem?) ...

Write a recursive function using dichotomy to insert objects in the database.

• If inserting all objects fails, split the list in two, recurse on both parts.
• Stop condition: when there is only one object in the list.
• Sum up results: return size of (successfully) inserted list.

This will allow faster database updates from big history files.

my system

$ uname -a
Linux novo 4.15.0-39-generic #42-Ubuntu SMP Tue Oct 23 15:48:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ zsh --version
zsh 5.4.2 (x86_64-ubuntu-linux-gnu)

my problem

when I open a the admin page I get a 500 error due to SQLite objects created in a thread can only be used in that same thread.

solution

add a get_session like to db.py

Session = sessionmaker(bind=engine)

def get_session():
    _engine = create_engine("sqlite:///%s" % DB_PATH)
    session = sessionmaker(bind=_engine)
    return session()

in order to create a new SQLite session (that will be destroyed)

my solution

this PR

@pawamoy thanks for your work

deactivate command from virtualenv will return none type if we compute it after execution, since the function unsets itself.

• VAR=value command do something: assign + command type?
• VAR=value: assign?
• function f { ... }: define?
• f() { ... }: define?

Any other?

pip output:

% pip install shellhistory
Collecting shellhistory
  Could not find a version that satisfies the requirement shellhistory (from versions: )
No matching distribution found for shellhistory

Maybe use this lib: https://flask-sqlalchemy.palletsprojects.com/en/2.x/quickstart/

It could fix #22

• bash history: write a function
• zsh history: write a function
• bashhub: bh -n 10000 > last-10k.log then parse (rcaloras/bashhub-client#52 😀 )

A simple Python script that prints out the database contents (respecting history file format) should be enough to start.

1. shellhistory.sh: provide the command-line tool with commands to enable and disable the extended shell history.
2. the database: database-related Python code
3. the web app: flask app to visualize the data, making use the database-related code
4. plugins: add subcommands to the CLI tool:
   • import data from file
   • export data to file
   • search database
   • CRUD rows in the database

sudo make install or sudo ./install.sh

• check if python3 is available, if not, exit with message
• check if virtualenv is available, if not install with apt-get install -y python3-virtualenv
• create the virtualenv somewhere, install the requirements
• create a script as /usr/bin/run-shell-history or else, with the right env vars
• output a message to tell user to source shellhistory.sh at startup (pastable line)

Also write an uninstall script:

• delete the virtualenv
• delete the run script

Post your ideas here!

Reminder of the available fields for analysis:

• start: command start time
• stop: command stop time
• duration: duration of the command
• uuid: session id, shared with subshells
• parents: process parents, newline-separated commands, something like:

  /bin/bash
  /usr/bin/python /usr/bin/x-terminal-emulator
  sh -c x-terminal-emulator
  tint2 -c /home/pawamoy/.config/tint2/tint2rc
  /sbin/init
  

• host: hostname
• user: username
• tty: something like /dev/pts/0 or /dev/tty1
• path: command working directory
• shell: shell used (/bin/bash, /bin/zsh, etc.)
• level: shell level (usually 2 in a GUI, 1 in a Ctrl-Alt-F1/6 TTY)
• type: command type (builtin, alias, function, file, keyword, none)
• code: command return code
• cmd: the command itself

Will this work with PowerShell on Linux/Windows Powershell?

Ctrl-C can be used to clear out the current typed content. But each time Ctrl-C is hit, shellhist is triggered with a return code of 130 and the typed content as command. I don't think people want these lines to be saved.

https://github.com/rcaloras/bash-preexec

If it's not, we can still rely on the parents field to compute it.

It seems to be working fine at first glance:

$ # in bash
$ echo $SHLVL
1
$ zsh
$ echo $SHLVL
2

...though SHLVL is defined in the Bash man page as follow:

SHLVL Incremented by one each time an instance of bash is started.

Maybe it's also used the same way by Zsh.

As the title says it cannot find the history.

Failed to import current history. The following exception occured: <class 'ValueError'>: /root/.shell_history/history: no such file

I am running Raspbian GNU/Linux 9 (stretch)

Any idea how to solve it?

Currently, in order to visualize data for multiple hosts, the user has to manually concatenate all his history files into one and import it, or import multiple files. The app should be able to do this automatically.

We must better handle duplicates and database updates.

It seems to be set to the user's default shell (in /etc/passwd). Appears as /bin/bash even in Zsh. Fortunately, the parents field holds the correct information.

While running the app, we could daemonize a history file reader which would insert the object in the database each time new lines are appended (new lines because of multiline commands).

The "sync data" button would then be deprecated in favor of an import feature (modal with file input for example). See #8.

The idea is to make the history file more readable for humans, but also easily importable by other tools.

I don't think there's a library for handling CSV files in Bash, and even if there was, I think it would slow down things a lot, which we don't want because shellhistory happens in interactive shells and we cannot let users wait for more than 200ms between each command. Appending a line to the history file must be as fast as possible.

But the CSV formatting is not hard either, so we could do it by hand. If I remember correctly, you can use any delimiter you want, as long as fields that contain it are enclosed in double-quotes. If these same fields also contain double-quotes, then you must simply double these.

Example with a comma as delimiter:

field 1,,field 3,"hey, I'm field 4!",,"he said ""4""? alright, then I'm gonna say ""6""!",field 7

Same string imported in GNumeric:

It's working, yay!

So instead of encoding parents and working directory in base 64, we could simply enclose them in double-quotes, and use some sed 's/"/""/g on it. And instead of prepending a colon on normal lines, and a semi-colon on extra command lines, we could also simply do the same for the command.

:...:echo "a
;b
;c" | wc -c

would become

...:"echo ""a
b
c"" | wc -c"

Also, just to make sure, we could also enclose hostname and user in double-quotes.