pavelkastornyy / ansi4j Goto Github PK

Configuration has only one property - environment. So, it is better to remove Configuration and move its settings to ParserFactory.

Currently when FunctionFinder finds some function for which developer hasn't provided parser (in ParserFactory) warn log message is created. I think it should be removed because developer knows what parsers he provided and therefore what functions we wants to parse.

At the moment when TextAttributeConfig is created concrete colors are used:

      int fgColor = 0xffffff;
      int bgColor = 0x000000;
      attributeConfig = new DefaultTextAttributeConfig.Builder()
                    .defaultForegroundColor(fgColor)
                    .defaultBackgroundColor(bgColor)
                    .extraColorsEnabled(true)
                    .palette16(palette)
                    .build();

I think instead of these colors palette indexes should be used, as all colors come from the palette.

I've been working on a terminal emulator using this library, and I'm a little confused as to how to actually use a FunctionFragment once you've obtained it. Text fragments seem simple enough, but a function fragment doesn't appear to offer any methods that help you understand what it is. Am I not doing this right?

while ((fragment = parser.parse()) != null) {
    if (fragment.getType() == FragmentType.FUNCTION) {
        FunctionFragment funcFragment = (FunctionFragment) fragment;
        // How to get function details?
    } else {
        writeText(fragment.getText());
    }
}

How do you actually use this as a dependency? Is it available in some maven repo? Are their jar files to download somewhere? Thanks for any clarification.

Currently we have different types of parsers and as a result API is not very clear. So, it is better to rename Fragment/Text/Function parsers to Fragment/Text/Function handlers.

I'm working on a mock terminal that supports Ansi. The problem is, it receives characters from a print stream, and therefore they can't be fed into the Ansi parser. Even if it needed to do some internal buffering, supporting this use-case would make your library much more powerful.