paulmelnikow / icedfrisby-nock Goto Github PK

In badges/shields#2195, we wanted to configure tests so the intercept()ed tests were skipped and the others were run. This required a way to check whether or not a test had an intercept in the chain.

With the tooling we had in place it was easy enough to conditionally call toss(). However there was no way to tell whether intercept() had been called.

Two possible fixes to this:

1. Add a property getter to allow inspecting whether an intercept has been placed. This seems useful regardless of whether the next option is also done.
2. Provide a skipIfIntercepted option that can be passed through config and/or chained on – any time before toss().

As mentioned in #27, it would be helpful to provide a skipIfIntercepted option that can be passed through config and/or chained on – any time before toss() or run().

This would be helpful for badges/shields#2195, we wanted to configure tests so the intercept()ed tests were skipped and the others were run.

This will need a skip() method added in IcedFrisby.

See badges/shields#5305

https://app.circleci.com/pipelines/github/badges/shields/2135/workflows/86b47726-8fc5-4d14-a857-0194da24eac7/jobs/110276/steps

In these test runs:

• https://circleci.com/gh/badges/shields/58497
• https://circleci.com/gh/badges/shields/58498

after reaching the error "TypeError: Cannot read property 'startsWith' of undefined", it appears that nock is not being cleaned up correctly. None of the subsequent pass.

See badges/shields#3616 (comment) for a little more explanation.

Hello there!

I've been working on adding some tests to the CodeClimate service in shields (see pull request 1613). I need to mock one request and allow other HTTP connections and therefore followed the example in the Readme.

Nevertheless the following error is thrown:
TypeError: t.create(...).get(...).intercept(...).networkOn(...).open is not a function

In the end I've come up with a solution that seems to work, but I'm reporting this issue anyway. 😉

Cheers,

Pyves

I want to track the bits of work related to finishing the upstream plugin support.

• Upstream changes
  • baseUri(): IcedFrisby/IcedFrisby#26
  • before(): IcedFrisby/IcedFrisby#28
  • finally()
  • Export the constructor: IcedFrisby/IcedFrisby#29
  • Release in npm
• Tasks
  • Update devDependencies
  • Remove constructor hack
  • Use finally, clean up better, and disable net connect by default