Scoping and CompiledScript.Execute vs ScriptEngine.Evaluate about jurassic HOT 5 CLOSED

Yep, that's definitely wrong, later declarations should override earlier ones.

I tried running this code in the latest version (v3.2.6):

static void Main(string[] args)
{
    var engine = new ScriptEngine();
    engine.SetGlobalValue("console", new Jurassic.Library.FirebugConsole(engine));
    engine.Execute(@"
        function main() {
            console.log('Script A');
        }
        main();");
    engine.Evaluate(@"
        function main() {
            console.log('Script B');
        }
        main();");
}

And it worked as expected. Likely it was fixed when I did a big overhaul of how scoping works a couple years back.

Note that this code prints "Script B" twice, and that's also correct (declarations are processed before code):

static void Main(string[] args)
{
    var engine = new ScriptEngine();
    engine.SetGlobalValue("console", new Jurassic.Library.FirebugConsole(engine));
    engine.Execute(@"
        function main() {
            console.log('Script A');
        }
        main();
        function main() {
            console.log('Script B');
        }
        main();");
}

from jurassic.

Thanks for your speedy reply (as always)!

I somehow thought it would be more work testing it out on 3.2.6. I should have given it a go.

I played around with your code and I'm seeing the same thing you're seeing.

Good to know that it's fixed in 3.2.6. We'll have to put some effort into getting the upgrade under way.

from jurassic.

If you don't want to update you may be able to clear out the value of "main" in between the two executions, e.g. something like engine.SetGlobalValue("main", Undefined.Value);. I haven't tried it but I guess that would fix it(?)

from jurassic.

Our scripts are entirely dynamic, and we do have some cases where we rely on variables declared in one script being accessed from others, so scope wiping between runs will break things.

I have started the upgrade. Looks doable for now.

from jurassic.

The code I pasted would only touch the value of "main" and nothing else (so not really "scope wiping"), but if the name of the function is dynamic then yeah that'd be problematic.

from jurassic.