Git Product home page Git Product logo

Comments (8)

johnanisere avatar johnanisere commented on August 16, 2024 3

@jaredwilli Sorry about your issue.I've been unable to replicate the issue.
Please note that you can only emulate ios/android devices in chrome dev tools using the network conditions tab.
screen shot 2019-01-14 at 1 00 11 pm
screen shot 2019-01-14 at 1 00 40 pm
screen shot 2019-01-14 at 1 01 22 pm

from react-smartbanner.

xanderdeseyn avatar xanderdeseyn commented on August 16, 2024

Running into this issue as well. Were you able to fix it jared?

from react-smartbanner.

Boorasso avatar Boorasso commented on August 16, 2024

Try setting the prop "force" to "ios" to view the ios smart banner in chrome on a computer.
Also did you make sure you cleared your cookies ? The banner won't reappear if you close it until you clear the cookie.

from react-smartbanner.

jaredwilli avatar jaredwilli commented on August 16, 2024

Actually my work priorities changed and I am no longer working on making this banner for our site. But I was not ever able to get it to work. Cookies were cleared, and I tried to use the force for ios but that didn't work.

from react-smartbanner.

awreese avatar awreese commented on August 16, 2024

I can confirm @johnanisere is correct, simulating the User Agent works for testing in the browser.

from react-smartbanner.

dovvas avatar dovvas commented on August 16, 2024

I had the same issue. I manipulated "setType(deviceType)" function and changed agent.device.vender === 'iOS' || agent.browser.name === 'Mobile Safari'. I know this way it doesn't support iOS < 6.

from react-smartbanner.

arpit-shrivastava-at-appointy avatar arpit-shrivastava-at-appointy commented on August 16, 2024

Anyone following up with this repo ? This is still happening in ios devices. Anyone can help ?

from react-smartbanner.

bastian-hidalgo avatar bastian-hidalgo commented on August 16, 2024

@arpit-appointy @dovvas @jaredwilli the reason that doesn't show on iOS devices its because @patw0929 doesn't want to give it, instead he propose to use the smart banner meta tag for iOS, look at the code:

  // iOS >= 6 has native support for Smart Banner
      } else if (
        agent.os.name === 'iOS' &&
        (this.props.ignoreIosVersion ||
          parseInt(agent.os.version, 10) < 6 ||
          agent.browser.name !== 'Mobile Safari')
      ) {
        type = 'ios';
      }

If you have a iOS version < 6 it will show you.

And i'm not saying that this is incorrect, in fact, use the meta tag for iOS:

<meta name="apple-itunes-app" content="app-id=myAppStoreID, app-argument=myURL">

As Apple suggest: https://developer.apple.com/documentation/webkit/promoting_apps_with_smart_app_banners

Obviously, is not customizable. but thats the reason.

from react-smartbanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.