Comments (6)
We've fixed it since then ;-)
from git-gui.
Heh, the fix was entertaining tho. git-cola/git-cola@cca03e3
I thought python was the only one that had whitespace code bugs ;-) but I got to learn that tcl has similar sharp edges in certain versions. When I transplanted the commits over I made sure to not include that buglet. As always, it's best to have these fixes upstream.
I've spammed this issue enough, though. cheers.
from git-gui.
FYI I have a copy of the ssh-askpass
in https://github.com/git-cola/git-cola/ that originated from the script in this project. Someone recently submitted a change that added a toggle checkbox, which is basically the feature request here.
I've been meaning to get this back upstream (along with other patches that touched that file). For this feature, this was the relevant commit:
One note -- It seems like our shebang lines have diverged. I don't know why. I'm not a tcl/tk/wish expert so I'd defer to the copy in the git-gui repo, personally.
@fmoralesc can you explain whether #!/usr/bin/env tclsh
is better than the #!/bin/sh
trick which ends up doing exec wish
? I don't know enough to judge tclsh
vs. wish
. I guess that change should have been made here in the first place.
In any case, I've opened a PR with all of the interesting commits from git-cola here:
It basically implements this feature, so I think this issue can be closed and tracked over there.
from git-gui.
@davvid For some reason, at the time in my system sh
would not interpret the file correctly unless the proper interpreter was given, so I decided to be more explicit. (Now, at this point I also have problems with the git-cola (3.6) provided ssh-askpass
; at some point the syntax of the file broke. I get this problem regardless of the shebang. But that's a separate problem.)
from git-gui.
I guessed, that's why I mentioned the version ;) (EDIT: turned out I had installed the git version but had forgotten to update since then... :p)
from git-gui.
This patch has been submitted upstream to the GIt core development list for the new maintainer. BTW, the current git-gui maintainer's fork is here:
https://github.com/prati0100/git-gui
This PR can be closed now (or maybe wait until the patch is acknowledged and accepted).
https://public-inbox.org/git/[email protected]/T/#u
from git-gui.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-gui.