[Discussion] Specification of SearchInput advanced search attribute parsing about patternfly-yew HOT 4 OPEN

I actually think I'll just leave it for now and revisit later. I would rather get around to adding search capabilities to other components.

from patternfly-yew.

I am wondering if we should actually implement such a logic in patternfly-yew. For the project I am working on, we might want to use something completely different (https://github.com/ctron/sikula/), despite using the a search input field.

I am not sure patternfly should define what search should look like.

On the other side, adding some "search" tooling/helpers would make sense. But maybe that's an optional thing, on top of the control itself.

from patternfly-yew.

I get your point. We can't really parse search in a way that is going to please everyone.

The functionality is only really used to construct a map which is passed down to an AdvancedSearchMenu which then displays the items.

If we have a good interface for the map, then it can just be supplied as a prop. However, the AdvancedSearchMenu can't really do anything other than let you edit the attributes independent of the entire search string. The question is whether we want to support that or whether we just offer support for opening an advanced menu the user has to develop themselves.

Dropping support would drastically simplify the search input code so I'm open to it.

from patternfly-yew.

Hm, I see. Maybe we should come up with a trait then? Providing a reasonable default implementation.

from patternfly-yew.