[discussion] More advanced icon support about patternfly-yew HOT 6 OPEN

I am wondering if, instead of Icon, we should just allow Html in such cases. Icon transforms into Html anyway.

from patternfly-yew.

Just because I again noticed it, GitHub also uses SVGs 😬

from patternfly-yew.

What are the advantages to having icons that aren't fixed width?

Sometimes the better match into the flow of … text :)

I had some major issues with SVG icons here. Getting them aligned. So I reverted back to font based icons.

Regarding the other questions, I think it makes sense to let users provide their own icons. Instead of forcing them into using Icon. I still think that we should use the Icon, but only when it's useful.

For this specific case I think it should be possible to add a style using Icon::with_style and add the required 1em there.

In general I think it makes sense to let user provide their own icons. But also find a balance between adding a good variety of icons, but not increasing the size or loading time too much.

from patternfly-yew.

Sometimes the better match into the flow of … text :)

That makes a lot of sense 😆

For this specific case I think it should be possible to add a style using Icon::with_style and add the required 1em there.

Needs an additional display:block but works.

In general I think it makes sense to let user provide their own icons

So we should implement props for doing this? I could add this to the dual list selector.

from patternfly-yew.

PNGs even. Weird.

<img class="emoji" alt="+1" height="20" width="20" src="https://github.githubassets.com/assets/1f44d-41cb66fe1e22.png">

from patternfly-yew.

But, there's a bunch of good icon sets out there. Font based or SVG based, I think we should be able to use all of them. For example: https://github.com/finnbear/yew_icons (not a how of the API, but still)

from patternfly-yew.