parttio / ace-widget Goto Github PK

Post them here.

I will take a look at it as fast as possible, because I returned from my school and holiday break.

~ David

The BlurEvent listens to the the 'editor-content' Event:
https://github.com/Sergio70/AceEditorV14/blob/ff76efb1024f2c24dc379b935f3b2fac2c79bdbf/src/main/java/com/hilerio/ace/BlurChanged.java#L11
This causes a call from the frontend to the backend every time the content changed (Not on Blur).

Further more a Listener is added to this event which updates the content.
https://github.com/Sergio70/AceEditorV14/blob/ff76efb1024f2c24dc379b935f3b2fac2c79bdbf/src/main/java/com/hilerio/ace/AceEditor.java#L30
Updating the content of the backend content will also cause an update in the frontend. We creating kind of a loop! Exactly this mechanism was causing the original issue #7.
@F0rce have you tested your solution with setting the Network speed to 'slow 3G' or typed really fast?

When I type quickly to the editor the cursor jumps at the end of text. It doesn't happen when I write slowly.
It hapens in version 1.4 Beta

Hi,
i opened an issue vaadin/directory#66 (comment) because
I cannot include in my vaadin 24 projects many addons because they are not visible in web pages.
One of this addon is ace-widget and i am just tested the 2.0.0 new version without success.
The problem is the same.
i get a javascript error

and the ace editor is not visible in web page.

i also tried to put ace-widget in whitelist
vaadin.whitelisted-packages = com.vaadin, org.vaadin, com.hilerio
but, it seems that this property is valid only for spring application, not for Quarkus application and anyway it doesnt work.

Any suggestion please?

See attached Screen recording. When I try to scroll in the editor using the mouse wheel, the vertical scrollbar flickers in and out. Scrolling by dragging the bar is completely impossible.

The Issue seems to be that the default value for the maxLines is set to an Object containing Infinity https://github.com/Sergio70/AceEditorV14/blob/5a661290de0f4a7935086f1aa226a6af7c694c66/src/main/resources/META-INF/resources/frontend/%40f0rce/ace-widget/ace-widget.js#L126 instead of a number. This does not work correctly with the underlying ace editor, since a Number or Falsy value is expected, not an Object.

As a workaround I set the maxLines to 0 manually in our Java-Code (aceEditor.setMaxlines(0);), but I think this should be fixed in general. Im not sure though what the best default value would be here. 0 works for our usecase, but maybe Infinity (without being packed in an object) would also work.

Hello @Sergio70 ,

this issue is just here to inform you, that in today (or in the next few days) I will be uploading a new version of the ace-editor. The last few days I was playing quite a bit with the ace-editor and found some small "issues" regarding visibility and flow. There was also a small mistake in the synchronisation of the current selection which was also fixed.

I think some people will appreciate these changes :)

Stay safe,
David

Hello,
in last version of this component we are facing an issue with focus/edit in this editor.

First click seem to only focus on the component but if you write something nothing happens (not even paste from clipboard).
After second click into editor it works correctly.

It looks like the first click only focuses the component but not enters the "edit mode"...

JS

Hi, The ace editor seems to have markerGroups and HoverTooltips to make it possible to display a message on mouseover for a marker. I couldn't find an equivalent in the wrappers API.

Hi there,

first of all: thank you for this component, really appreciate the time!

Following setters would be nice:
setShowPrintMargin(boolean value);
setShowInvisibles(boolean value);
setShowGutter(boolean value);
setHighlightActiveLine(boolean value);

Hello,
There seems to be an issue with ace editor scrollbars. I don't see any scrollbar whatsoever (in resources view in browser the css display property is flickering to none and back).
I'm attaching screenshot with visible display:none;. If i put display: block !important to ace_scrollbar-v class the scrollbar is shown correctly. But I can't seem to change it permanently in vaadin.
I tried to create file: /frontend/themes/classic/components/ace-widget.css (according to documentation of Vaadin). but it has no effect. The css file has content as follows:

.ace_scrollbar-v { display: block !important; }

I am using Vaadin 24.3.9.

I saw there was a similar issue which was closed as resolved.

THX
JS

will keep you updated

I think that AceEditor.class -> public void setTheme(AceTheme theme) is missing:
this.editorTheme = theme;

Hello everyone,

the last 3 weeks, I worked really hard on this widget and I'm really proud to say that version v1.0.0 is finally stable and ready to release.

I would like to thank @Sergio70 for trusting me and letting me contribute as much as I did and I really hope to continue my contribution in the future.

I'm going to write a full documentation by the end of the week.

Yours sincerely,
David

Dear @Sergio70,

it was a great pleasure working with you. I really want to thank you, for trusting me and letting me contribute as much as I wanted / needed to.

With Polymer 3 / Polymer-Element going end of life pretty soon and Vaadin's full support of Lit-Element (the newest and faster Webcomponent framework) I created a whole new version of the ace editor. With more functions, better lifecyle and so on.

I already told the people, that had problems with the current version ( #58 #56 ), to switch to the newer version to fix their issues, which was a great success.

So from now on, I will be focussing / maintaing the newer / current version of the ace editor:
https://github.com/f0rce/ace <-- Vaadin Add-on source code
https://github.com/f0rce/lit-ace <-- Frontend source code
https://vaadin.com/directory/component/ace <-- Vaadin Directory
https://www.npmjs.com/package/@f0rce/lit-ace <-- Frontend NPM package
https://docs.f0rce.de/ace <-- Documentation

I hope you are doing well in those difficult times and I hope that we will keep in touch.

Have a great day,
David Dodlek