Comments (14)
dabowman
commented on August 19, 2024
1
make sure dropdowns are the same width as their triggers.
from wp-parsely.
dabowman
commented on August 19, 2024
1
The little secondary accordions in title suggestions should be the same width as the main panel header accordion. The chevrons on the right should align.
from wp-parsely.
dabowman
commented on August 19, 2024
1
In Figma the accordion triggers don't have the same 16px right and left padding as the items inside the accordion. from wp-parsely.
dabowman
commented on August 19, 2024
1
Looks like the fill of this svg got baked in by Figma when you exported it. Should be like the core ones where it get's its color from the css. from wp-parsely.
dabowman
commented on August 19, 2024
1
The title suggestions items should be wrapped separate from the trigger. The wrapper should have a 16px gap with 16px padding on left, right, bottom and 6px on the top. There should be no space between the trigger and that wrapper. from wp-parsely.
vaurdan
commented on August 19, 2024
1
@dabowman I have 👍 the issues that have been addressed in #2279, which was now merged.
from wp-parsely.
dabowman
commented on August 19, 2024
I don't think we need the undo option in the snackbar confirmation when you apply a title suggestion. We've already got the confirmation dialog and the option to restore in the sidebar.
from wp-parsely.
dabowman
commented on August 19, 2024
Figma for referencefrom wp-parsely.
dabowman
commented on August 19, 2024
Looks like this might just be specific to the pinned container. The suggestions container already has a wrapper.
from wp-parsely.
acicovic
commented on August 19, 2024
When looking into this issue, we should also look into the patch iteration comments:
@dabowman, some of these comments are addressed towards you. Also pinging @vaurdan here for awareness.
from wp-parsely.
acicovic
commented on August 19, 2024
Also, there are a couple of comments in our redesign PR:
from wp-parsely.
acicovic
commented on August 19, 2024
@vaurdan and @dabowman, so it seems all the comments in this thread have been addressed? In this case, the only remaining item is figuring out what to do with #2268 (comment). Let's look/discuss that one shortly, so we close this issue. I'd like us to close it within the interlude if possible.
Also, @dabowman, if you've seen anything else that we haven't addressed, please let us know.
Thank you both! 🙂
from wp-parsely.
vaurdan
commented on August 19, 2024
@acicovic The issues discussed in #2268 have been addressed. (my comment here).
If you agree, this issue can be closed after #2324 is merged.
from wp-parsely.
acicovic
commented on August 19, 2024
If you agree, this issue can be closed after #2324 is merged.
I totally agree, and I've updated that PR's description so this issue gets auto-closed when the PR gets merged.
from wp-parsely.
Related Issues (20)
- Excerpt Generator error/info message should not be persistent
- Edge Case: Blank error in some PCH panels when no credentials set HOT 3
- Fix failing E2E test
- Release wp-parsely 3.13.1
- Violation warning when adding the Recommendations Block HOT 1
- Release wp-parsely 3.13.2
- PCH: show list of smart links generated HOT 2
- PCH: generate headings in draft post
- PCH: add Recs Block to sidebar HOT 3
- Release wp-parsely 3.13.3
- Please make monthly increments available for data retention in the Parse.ly dashboard HOT 5
- Improve the Content Helper's UI
- Update Content Helper API Endpoints
- Release wp-parsely 3.14.0
- Release wp-parsely 3.14.1 HOT 1
- Release wp-parsely 3.14.2
- PCH Smart Linking: Undo doesn't work for All Blocks option HOT 1
- Discussion on Fixing the 'faultyEscapeUrl' Function to Prevent XSS Vulnerabilities HOT 1
- Release wp-parsely 3.14.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-parsely.