Comments (14)
make sure dropdowns are the same width as their triggers.
from wp-parsely.
The little secondary accordions in title suggestions should be the same width as the main panel header accordion. The chevrons on the right should align.
from wp-parsely.
![Screenshot 2024-03-08 at 2 29 24 PM](https://private-user-images.githubusercontent.com/5473066/311373070-9142b9a9-0193-42dc-888b-7c10cec9e524.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3MDExODIsIm5iZiI6MTcxMjcwMDg4MiwicGF0aCI6Ii81NDczMDY2LzMxMTM3MzA3MC05MTQyYjlhOS0wMTkzLTQyZGMtODg4Yi03YzEwY2VjOWU1MjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MDlUMjIxNDQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Yzk5Nzc3ZDVmMmY3NmEyNTI5ZThhZWQxYTZhOGE5ODk3ZjE0MDU5NWYzN2JjOTIxMjJmMzcyOTYzMmI0YTMyMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.vlVRAFIZ_wF09OIeODSDLq1nL0ntM14RbRK_pyGgsQc)
from wp-parsely.
![Screenshot 2024-03-08 at 2 31 24 PM](https://private-user-images.githubusercontent.com/5473066/311373464-0349d272-9a79-433f-922c-431e13cbb0fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3MDExODIsIm5iZiI6MTcxMjcwMDg4MiwicGF0aCI6Ii81NDczMDY2LzMxMTM3MzQ2NC0wMzQ5ZDI3Mi05YTc5LTQzM2YtOTIyYy00MzFlMTNjYmIwZmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MDlUMjIxNDQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjhlMTQwZjlkMDRiYjI2OWFlNGNjNjdjN2U4NGI4N2ZjZjQ4YjExYTczOGQwMzkwNmIxY2Y4YTdiNzc4YzQyOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EHy2IIrKQiRzOeBN7faxrzHSi5XSJZ-sre9uBZ9sbOk)
from wp-parsely.
![Screenshot 2024-03-08 at 2 33 25 PM](https://private-user-images.githubusercontent.com/5473066/311373838-1748c6ac-7372-41a0-b8ba-8083c201df6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3MDExODIsIm5iZiI6MTcxMjcwMDg4MiwicGF0aCI6Ii81NDczMDY2LzMxMTM3MzgzOC0xNzQ4YzZhYy03MzcyLTQxYTAtYjhiYS04MDgzYzIwMWRmNmUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MDlUMjIxNDQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjFmOGJiYzExOTJiNzRlMDE0Y2EyYzY2M2M1ZDhkYmZhNWY5ZjVkOGUyZGJjNTczOTE3MTRiNWYwYmRhOWM4OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.VNwlDCjVOTjDWSw8daNk31mVxK0lsfzOn923QvEBpt4)
from wp-parsely.
@dabowman I have 👍 the issues that have been addressed in #2279, which was now merged.
from wp-parsely.
I don't think we need the undo option in the snackbar confirmation when you apply a title suggestion. We've already got the confirmation dialog and the option to restore in the sidebar.
from wp-parsely.
![Screenshot 2024-03-08 at 2 35 51 PM](https://private-user-images.githubusercontent.com/5473066/311374285-7be81985-5817-48f7-bfdf-7988a7a7b06a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3MDExODIsIm5iZiI6MTcxMjcwMDg4MiwicGF0aCI6Ii81NDczMDY2LzMxMTM3NDI4NS03YmU4MTk4NS01ODE3LTQ4ZjctYmZkZi03OTg4YTdhN2IwNmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MDlUMjIxNDQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWNiYzA1YWU3NmI2MmEyNzdhNzNjODM3ZTE0NDM2NmE1NTRkM2VjZWIyZTQ0ZDBjODkyMmE1YjZkYmYxYWM5ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.24h4NcHgZHM6jR8z-m2w7LYMcdG5PpJ6NIwk_Sk3u9w)
from wp-parsely.
Looks like this might just be specific to the pinned container. The suggestions container already has a wrapper.
from wp-parsely.
When looking into this issue, we should also look into the patch iteration comments:
@dabowman, some of these comments are addressed towards you. Also pinging @vaurdan here for awareness.
from wp-parsely.
Also, there are a couple of comments in our redesign PR:
from wp-parsely.
@vaurdan and @dabowman, so it seems all the comments in this thread have been addressed? In this case, the only remaining item is figuring out what to do with #2268 (comment). Let's look/discuss that one shortly, so we close this issue. I'd like us to close it within the interlude if possible.
Also, @dabowman, if you've seen anything else that we haven't addressed, please let us know.
Thank you both! 🙂
from wp-parsely.
@acicovic The issues discussed in #2268 have been addressed. (my comment here).
If you agree, this issue can be closed after #2324 is merged.
from wp-parsely.
If you agree, this issue can be closed after #2324 is merged.
I totally agree, and I've updated that PR's description so this issue gets auto-closed when the PR gets merged.
from wp-parsely.
Related Issues (20)
- Excerpt Generator error/info message should not be persistent
- Edge Case: Blank error in some PCH panels when no credentials set HOT 3
- Fix failing E2E test
- Release wp-parsely 3.13.1
- Violation warning when adding the Recommendations Block HOT 1
- Release wp-parsely 3.13.2
- PCH: show list of smart links generated HOT 2
- PCH: generate headings in draft post
- PCH: add Recs Block to sidebar HOT 3
- Release wp-parsely 3.13.3
- Please make monthly increments available for data retention in the Parse.ly dashboard HOT 5
- Improve the Content Helper's UI
- Update Content Helper API Endpoints
- Release wp-parsely 3.14.0
- Release wp-parsely 3.14.1 HOT 1
- Release wp-parsely 3.14.2
- PCH Smart Linking: Undo doesn't work for All Blocks option HOT 1
- Discussion on Fixing the 'faultyEscapeUrl' Function to Prevent XSS Vulnerabilities HOT 1
- Release wp-parsely 3.14.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-parsely.