Git Product home page Git Product logo

Comments (3)

acicovic avatar acicovic commented on September 28, 2024

Currently assigning this to the 3.13.1 milestone, but might push it to another milestone if it needs work that will take some time.

from wp-parsely.

acicovic avatar acicovic commented on September 28, 2024

After further looking into this, here are my conclusions:

  • The component handles errors as it should.
  • The issue with the blank panel occurs only with the testing scenario outlined above, which is an edge case. Although it could occur, the ROI is probably very low if we need significant work for a refactor to make this work.

The root of the issue is that in the specific state, the window.wpParselyEmptyCredentialsMessage variable is undefined, and we're calling the EmptyCredentialsMessage component which uses that variable as the value to display. Given that, there's nothing to display, and thus the blank panel.

I don't think there's particular urgency in releasing a fix for this and we may need to touch different places in the code, so I'm removing it from the 3.13.1 milestone.

from wp-parsely.

acicovic avatar acicovic commented on September 28, 2024

Update: This also affects the Excerpt Generator when tested similarly. In this case the panel's content will not vanish, but it will display an empty notice which is visible by the blue border on the left.

from wp-parsely.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.