Comments (3)
Currently assigning this to the 3.13.1 milestone, but might push it to another milestone if it needs work that will take some time.
from wp-parsely.
After further looking into this, here are my conclusions:
- The component handles errors as it should.
- The issue with the blank panel occurs only with the testing scenario outlined above, which is an edge case. Although it could occur, the ROI is probably very low if we need significant work for a refactor to make this work.
The root of the issue is that in the specific state, the window.wpParselyEmptyCredentialsMessage
variable is undefined, and we're calling the EmptyCredentialsMessage
component which uses that variable as the value to display. Given that, there's nothing to display, and thus the blank panel.
I don't think there's particular urgency in releasing a fix for this and we may need to touch different places in the code, so I'm removing it from the 3.13.1 milestone.
from wp-parsely.
Update: This also affects the Excerpt Generator when tested similarly. In this case the panel's content will not vanish, but it will display an empty notice which is visible by the blue border on the left.
from wp-parsely.
Related Issues (20)
- PCH Smart Linking: Improve Classic Block handling HOT 6
- Extract options functionality to a new class
- Consider polyfill solution to allow wp-scripts upgrades HOT 2
- Smart Linking: Empty Review Smart Links modal
- Smart Linking: Review modal alters styling in PCH Sidebar
- PCH: include AI label in AI-powered features HOT 2
- UTMs blocking ability for customer to export report data
- Release wp-parsely 3.16.1
- Fix Gutenberg deprecation warnings
- Smart Linking should not suggest links inside headings/captions
- Release wp-parsely 3.16.2 HOT 1
- PCH: ability to filter Related Posts by multiple Sections HOT 1
- PCH: show me performance data points on suggested smart links
- PCH: let me preview a smart link recommendation from the review modal HOT 2
- Errors when editing widgets inside of Customizer HOT 5
- Release wp-parsely 3.16.3
- Smart Linking: Implement "Apply to selection" mode HOT 4
- Excerpt Suggestions: Allow different personas/styles HOT 3
- Release wp-parsely 3.16.4
- Consider using no-misused-promises and no-floating-promises ESLint rules
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-parsely.