pariz / gountries Goto Github PK

I prepared a repo where you can use the CLI to fetch the newest ISO 3166 list or use the countries.json file. https://github.com/detrin/download-iso3166-list

Carribean Netherlands (BQ) & Saint Helena (SH) country definitions are missing

because I found the TW ccn3 is different with ISO 4217 wiki: https://www.wikiwand.com/en/ISO_4217, current TW ccn3 is 158, but wiki is 901

gountries.New().FindCountryByName("United States of America") 

does not return a country where this does

gountries.New().FindCountryByName("United States") 

"United States of America" should be valid based on

name:
  common: United States
  official: United States of America

Please extend this method to include official and native text.

Thank you!

Few missing countries:

• Brunei Darussalam
• Caribbean Netherlands
• East Timor
• Sao Tome and Principe
• U.S. Virgin Islands

I'm planning on using your library as part of an API and I was going to make a few changes to get faster lookups and embed the data directly into the binary to make it easier to deploy. Interested in a pull request?

Planned features:

1. Embed the country data from the YAML files using go-bindata so that the deployment remains a single binary without relying on an external data directory. This would be backwards compatible so that when you populateCountries or populateSubdivisions it checks the bindata first and then falls back to the data directory.
2. Use a bidirectional tree map from the gods library so that lookups by either country name or alpha code are more efficient.
3. Support returning either all of the data or a particular subset of countries as a struct that is easily marshaled to JSON. This is useful to populate a frontend web UI for entering billing/shipping addresses.

This could simplify some of the query functions by using the tree to do lookups, rather than looping through all of the available data.

I'm going to fork your library and work on this a little bit. Let me know if you have any other ideas.

I think, we should get rid of global instances at all

q1 := gountries.NewFromPath('path1') 
q2 := gountries.NewFromPath('path2') // SURPRISE! q2 actually is q1

The ISO 3166-2 subdivision codes have the NO- prefix whereas other countries do not.

Please add git releases to each build of this package, so that we can use them within our package management tool.

I faced with 2 issues

• go get doesn't fetch content of data directory so it's empty after obtaining a project
• example code fails with panic panic: Error loading Countries because it expects current directory of executable to contain data directory. But it's actually not there but inside github.com/pariz/gountries

This makes the library pretty unsuitable for use in real-world applications. Currently, in order to get, e.g., a Country's list of Subdivisions, it creates a new Query every time you call it. This is horribly inefficient.

Probably the best way to solve this is make one Query and either make it a global variable that is initialized during package initialization, or allow it to be explicitly initialized if that isn't acceptable.

https://raw.githubusercontent.com/pariz/gountries/master/data/json/subdivisions/ye.json

See:
"Name": "Al Bay?a'",

Do you suppose there's a way to add a subdivision.Names.Common - non-special char name for every subdivision like you have for country?

Some countries have a trailing "(the)" in the ISO short name - for example, the USA: https://www.iso.org/obp/ui/#iso:code:3166:US

When gountries is missing this, it causes validations to fail.
Could these please be added, potentially behind a feature toggle?

Hello!

Would it be possible to either:

• Remove the error formatting which introduces the gountries error part or
• Make it customizable ?

Sometimes we want to return the error from gountries to expose what's wrong to the API user, but the gountries part can create confusion as to what's wrong.

Thanks!

Good Go style is to use lower-case letters to start error messages, and start with the package name, which makes them easily composable. See https://golang.org/doc/effective_go.html#errors

Hello and thanks for sharing.

I noticed that your data contains unicode symbols in data/json/countries/ while \u<number> form is used in countries.json. Has it been done intentionally?

Is it possible to use plain unicode in countries.json too? I believe it's better for readability and grammar checking.

Last release is from 2017. Seems like it's due for an update, as I've seen many and additions to the codebase :).

The methods for countries sometimes take pointer receivers, and sometimes take struct receivers. They should be made consistent. My preference would be to use pointers everywhere in this library, because the data structures are frequently large and shouldn't be needlessly copied.

Found three countries missing:

• AC (Ascension Island) https://www.iso.org/obp/ui/#iso:code:3166:AC
• TA (Tristan da Cunha) https://www.iso.org/obp/ui/#iso:code:3166:TA
• XK (Kosovo) https://countrycode.org/kosovo

I'm not sure about last one, looks like there is some political context. But iso.org has AC and TA codes.

The codes for subdivisions in China are all numeric. This was changed in 2017-11-23 (see this).

So the current code for Sichuan is 51, but should be SC

Where does the source data (data directory) comes from?

I Expect England to be present in UK's subdivisions
https://en.wikipedia.org/wiki/ISO_3166-2:GB

The calling code for Curaçao is currently returning incorrectly as 5999, however the correct calling code should be 599

Isn't there a way of getting a list of all countries?

Would you be willing to accept a PR that adds translated country names to NameToAlpha2? I've run into several cases where lookups by name have failed but the spelling variant is among the translations.