Different gas value for `weight_to_fee()` in ink! integration and e2e tests about ink HOT 6 CLOSED

The code responsible for the function always returning 0:

	fn convert(weight: Weight) -> BalanceOf<T> {
		<NextFeeMultiplier<T>>::get().saturating_mul_int(Self::weight_to_fee(weight))
	}

from ink.

Regarding the observation you made: The 0 is intentional, as the comment indicates, "Equivalent to the newer [seal1][super::api_doc::Version2::weight_to_fee] version but works with ref_time Weight only." (proof_size is set to 0).
The issue you observed is related to the runtime configuration. By changing type FeeMultiplierUpdate = () to type FeeMultiplierUpdate = SlowAdjustingFeeUpdate<Self> in pallet_transaction_payment::Config for Runtime, you can make it work.

from ink.

@arturoBeccar, please advise if it works for you, and can we close the issue?

from ink.

Hi @smiasojed, recompiling the node on commit f1d8389 , and calling a contract with this function:

 #[ink(message)]
        pub fn weight_to_fee(&self, gas: u64) -> Balance {
            self.env().weight_to_fee(gas)
        }

We still obtain 0 with any gas number in e2e.

Any idea on why this is happening?

from ink.

Hi @arturoBeccar,
This is how I tested it:

1. I recompiled the substrate-contract-node on commit 'f1d8389.'
2. I started the node.
3. I added the 'weight_to_fee' message to the Flipper contract.
4. I instantiated it.
5. I called 'weight_to_fee':
   cargo contract call --suri //Alice --manifest-path ../ink/integration-tests/flipper/Cargo.toml --contract 5D4NHEJyj56T7J9TXZwUjmuWBzecFvEunX51GmRmcv1igd8s --message weight_to_fee --args 10
Result Ok(9)
   Do you verify it in the same manner?

from ink.

Hi @smiasojed. I tried the suggested steps and it worked correctly. I confirm the issue is now resolved in PR #219 to substrate-contract-node and can be closed. Thanks!

from ink.