Comments (6)
After some investigation, it would be difficult to support non-standard generic account types in both unit and e2e testing. This is due to the fact that the testing environment assumes AccountId: From<[u8; 32]>
allowing the convert keypairs from subxt
into public addresses and so on, it is also used when generating default test accounts (Alice, Bob, Dave, ...) assuming the From<[u8; 32]>
implementation.
Making this generic can be done with:
- Introducing the const generic
N
forFrom<[u8; N]>
allowing the developer to specify the size of theAccountId
manually - Completely removing the notion of
From<>
and introducing the traitDefaultAccounts
and other traits allowing the developer to specify default test accounts himself
The second approach is less feasible because the E2E framework heavily relies on sr25519 for signing transactions, and uses default polakdot config.
Making this customisable would probably require a lot of configuration on the developer side, something that we want to avoid.
If you want to test your contracts with non-32-byte AccountId
, I suggest you do this on the frontend side using JavaScript.
from ink.
It is a good spot we should make AccountId
more generic. The fix in tests should easy. However, the reason why you might not be able to instantiate the contract is because pallet-contracts
is configured to use the default AccountId
.
If you are using some custom node configuration, can you please provide the link so I can reproduce the issue?
from ink.
The custom node is frontier. So basically that node with pallet-contracts
setup (similar to this).
However, you mentioned that pallet-contracts
uses AccountId
. Do you mean pallet-contracts
defaults to AccountId32
? From what I just checked, it uses AccountId
provided by frame_system
pallet
from ink.
Do you mean
pallet-contracts
defaults toAccountId32
Essentially, yes, substrate-contracts-node
using AccountId32
which resolves to [u8; 32]
.
Off-chain testing environment makes an assumption about this in order to generate a set of default accounts. I need to think about the proper way to make AccountId
configurable, coz this breaks some assumptions in our testing frameworks
from ink.
Yeah. Probably AccountId
should be configurable but also have a default value if none is specified
from ink.
How you suggest I do that? @SkymanOne
from ink.
Related Issues (20)
- The function `set_contract_storage` in integration test it's missing a size check.
- Linter: Unprotected `terminate_contract`
- Linter: Unprotected `DelegateCall` call
- Immutable contracts allowed to change state via `env` HOT 4
- Add a lint for missing `no_main`
- IIP-3: Allow messages without `&self` receiver; opt out of automatic storage loading HOT 5
- Different gas value for `weight_to_fee()` in ink! integration and e2e tests HOT 6
- Split up `ink_linting` into two `dylint` libraries HOT 1
- Use standard Github's machines for test jobs
- Linter: Warn about using non-fallible APIs for `Lazy` and `Mapping` HOT 1
- Support expressions for `extension` and `function` during chain extension definition
- Event defintions with generics
- Deprecation of "legacy" inline events HOT 1
- Unify `call-runtime` and `e2e-call-runtime` examples
- Linter: Dangereous `self.env().transferred_value()` pattern
- Linter: Divide before multiply
- Add support and integration test for `caller_is_root`
- Migrate ink! CI from organization runners to standard GitHub runners
- Add links to linter warning details on use.ink
- Cross contract calling produces unsupported code HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ink.